Bug 1112603

Summary:	Internal Error: `ipa sudorule-mod rule --order=`
Product:	Red Hat Enterprise Linux 7	Reporter:	Martin Kosek <mkosek>
Component:	ipa	Assignee:	Martin Kosek <mkosek>
Status:	CLOSED ERRATA	QA Contact:	Namita Soman <nsoman>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	7.0	CC:	rcritten, xdong
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ipa-4.0.3-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-05 10:12:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Kosek 2014-06-24 10:15:06 UTC

This bug is created as a clone of upstream ticket:
https://fedorahosted.org/freeipa/ticket/4360

i.e., cannot unset sudoorder attribute even though it's marked as optional

{{{
[Thu May 29 14:50:11.331855 2014] [:error] [pid 992] ipa: DEBUG: sudorule_find(None, sudoorder=None, all=False, raw=False, no_members=False, pkey_only=False)
[Thu May 29 14:50:11.338142 2014] [:error] [pid 992] ipa: ERROR: non-public: TypeError: %d format: a number is required, not NoneType
[Thu May 29 14:50:11.338158 2014] [:error] [pid 992] Traceback (most recent call last):
[Thu May 29 14:50:11.338163 2014] [:error] [pid 992]   File "/usr/lib/python2.7/site-packages/ipaserver/rpcserver.py", line 343, in wsgi_execute
[Thu May 29 14:50:11.338167 2014] [:error] [pid 992]     result = self.Command[name](*args, **options)
[Thu May 29 14:50:11.338172 2014] [:error] [pid 992]   File "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 436, in __call__
[Thu May 29 14:50:11.338176 2014] [:error] [pid 992]     ret = self.run(*args, **options)
[Thu May 29 14:50:11.338180 2014] [:error] [pid 992]   File "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 752, in run
[Thu May 29 14:50:11.338184 2014] [:error] [pid 992]     result = self.execute(*args, **options)
[Thu May 29 14:50:11.338188 2014] [:error] [pid 992]   File "/usr/lib/python2.7/site-packages/ipalib/plugins/baseldap.py", line 1344, in execute
[Thu May 29 14:50:11.338192 2014] [:error] [pid 992]     *keys, **options)
[Thu May 29 14:50:11.338196 2014] [:error] [pid 992]   File "/usr/lib/python2.7/site-packages/ipalib/plugins/sudorule.py", line 330, in pre_callback
[Thu May 29 14:50:11.338200 2014] [:error] [pid 992]     self.obj.check_order_uniqueness(*keys, **options)
[Thu May 29 14:50:11.338205 2014] [:error] [pid 992]   File "/usr/lib/python2.7/site-packages/ipalib/plugins/sudorule.py", line 288, in check_order_uniqueness
[Thu May 29 14:50:11.338209 2014] [:error] [pid 992]     'rule': rule_name,
[Thu May 29 14:50:11.338237 2014] [:error] [pid 992]   File "/usr/lib/python2.7/site-packages/ipalib/text.py", line 257, in __mod__
[Thu May 29 14:50:11.338245 2014] [:error] [pid 992]     return self.__unicode__() % kw
[Thu May 29 14:50:11.338250 2014] [:error] [pid 992] TypeError: %d format: a number is required, not NoneType

}}}

Comment 1 Martin Kosek 2014-06-24 10:16:33 UTC

Fixed upstream:

master:

637ef11109600d87bfb783eadd4b6401fa58d468 sudorule: Allow unsetting sudoorder

Comment 3 Xiyang Dong 2015-01-05 15:39:38 UTC

verified on ipa-server-4.1.0-13.el7.x86_64:

[root@hp-dl380pgen8-01 ~]# ipa sudorule-mod --help|grep order
  --order=INT           integer to order the Sudo rules
[root@hp-dl380pgen8-01 ~]# ipa sudorule-add testrule1
---------------------------
Added Sudo Rule "testrule1"
---------------------------
  Rule name: testrule1
  Enabled: TRUE
[root@hp-dl380pgen8-01 ~]# ipa sudorule-mod testrule1 --order=1
------------------------------
Modified Sudo Rule "testrule1"
------------------------------
  Rule name: testrule1
  Enabled: TRUE
  Sudo order: 1
[root@hp-dl380pgen8-01 ~]# ipa sudorule-show testrule1 
  Rule name: testrule1
  Enabled: TRUE
  Sudo order: 1

Comment 5 errata-xmlrpc 2015-03-05 10:12:39 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0442.html