Bug 1112865

Summary: Product removal help tip is not displayed and removal button is not hidden when a product is published in a CV, etc.
Product: Red Hat Satellite Reporter: Walden Raines <walden>
Component: Content ManagementAssignee: Walden Raines <walden>
Status: CLOSED CURRENTRELEASE QA Contact: sthirugn <sthirugn>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.0.3CC: bbuckingham, jmontleo, sthirugn
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/6366
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-09-11 12:24:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Walden Raines 2014-06-24 21:03:36 UTC
The product removal help tip is only being displayed when a user does not have permission to remove the product instead of in all the cases it should be displayed.  The remove button is also not hidden as it should be.

Products should not be able to be deleted if they have been published in a content view or if the product is a Red Hat product.

h3. Steps to Reproduce

# Create a product
# Make it "readonly" by doing one of the above actions
# Notice the delete button is still there and the help tip is not

Comment 1 Walden Raines 2014-06-24 21:03:37 UTC
Created from redmine issue http://projects.theforeman.org/issues/6366

Comment 2 Walden Raines 2014-06-24 21:03:42 UTC
Upstream bug assigned to walden

Comment 4 Walden Raines 2014-06-25 14:24:13 UTC
PR: https://github.com/Katello/katello/pull/4343

Comment 5 Walden Raines 2014-06-26 14:12:49 UTC
commit a39239bd164bb0923c55a4248a5ba66e2dd903c7
Merge: 7223630 302479b
Author: Walden Raines <walden>
Date:   Thu Jun 26 10:11:35 2014 -0400

    Merge pull request #4343 from waldenraines/6366
    
    Fixes #6366/BZ1112865 - restore readonly product functionality.

commit 302479bf62495c57cd64083b5af27eea14923609
Author: Walden Raines <walden>
Date:   Wed Jun 25 10:20:43 2014 -0400

    Fixes #6366/BZ1112865 - restore readonly product functionality.
    
    When replacing the authorization system we removed the logic
    that determines whether or not a product is read only.  This commit
    restores that logic.

Comment 7 sthirugn@redhat.com 2014-09-03 15:17:09 UTC
Verified.

For a "Viewer" user, the Product -> Remove button is hidden and the helptip is displayed saying that they do not have permissions to remove.

Version Tested:
GA Snap 7 - Satellite-6.0.4-RHEL-6-20140829.0

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.23-1.el6_5.noarch
* candlepin-common-1.0.1-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.23-1.el6_5.noarch
* candlepin-tomcat6-0.9.23-1.el6_5.noarch
* elasticsearch-0.90.10-6.el6sat.noarch
* foreman-1.6.0.42-1.el6sat.noarch
* foreman-compute-1.6.0.42-1.el6sat.noarch
* foreman-gce-1.6.0.42-1.el6sat.noarch
* foreman-libvirt-1.6.0.42-1.el6sat.noarch
* foreman-ovirt-1.6.0.42-1.el6sat.noarch
* foreman-postgresql-1.6.0.42-1.el6sat.noarch
* foreman-proxy-1.6.0.30-1.el6sat.noarch
* foreman-selinux-1.6.0.14-1.el6sat.noarch
* foreman-vmware-1.6.0.42-1.el6sat.noarch
* katello-1.5.0-30.el6sat.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.6-1.el6sat.noarch
* katello-installer-0.0.62-1.el6sat.noarch
* openldap-2.4.23-34.el6_5.1.x86_64
* openldap-devel-2.4.23-34.el6_5.1.x86_64
* pulp-katello-0.3-4.el6sat.noarch
* pulp-nodes-common-2.4.1-0.5.rc1.el6sat.noarch
* pulp-nodes-parent-2.4.1-0.5.rc1.el6sat.noarch
* pulp-puppet-plugins-2.4.1-0.5.rc1.el6sat.noarch
* pulp-puppet-tools-2.4.1-0.5.rc1.el6sat.noarch
* pulp-rpm-plugins-2.4.1-0.5.rc1.el6sat.noarch
* pulp-selinux-2.4.1-0.5.rc1.el6sat.noarch
* pulp-server-2.4.1-0.5.rc1.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch

Comment 8 Bryan Kearney 2014-09-11 12:24:37 UTC
This was delivered with Satellite 6.0 which was released on 10 September 2014.