Bug 1113392
| Summary: | Review Request: xorg-x11-drv-libinput - Xorg X11 libinput input driver | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Hutterer <peter.hutterer> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ahmadsamir3891, e, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-24 23:52:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Hutterer
2014-06-26 05:54:07 UTC
Just a hint, you only need to keep github tags with version filled only, and then use this in the SPEC(Assume that the tag is v0.1.1): Source0: https://github.com/whot/xf86-input-libinput/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz yeah, thanks. I'm planning to move this driver over to xorg eventually once libinput stabilises a bit so I'd prefer to keep the same tag names as all the other drivers, hence the odd double-name in the tarball. OK. Another hint is that you can drop Requires: pkgconfig in the -devel. RPM will add it. both files updated, only change is dropping the Requires: pkgconfig line Updated to upstream 0.1.2. Dropped the pkgconfig file, and thus the -devel package. Spec URL: http://people.freedesktop.org/~whot/xorg-x11-drv-libinput.spec SRPM URL: http://people.freedesktop.org/~whot/xorg-x11-drv-libinput-0.1.2-1.fc21.src.rpm Review: + mock build is successful for f22. + rpmlint output on rpms gave 3 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as (sha256sum) srpm tarball :3737be379af423833d4a258c9d0dd174e21c9c94550f18bcc2224dcd9e16c5ac upstream tarball :3737be379af423833d4a258c9d0dd174e21c9c94550f18bcc2224dcd9e16c5ac + License "MIT" is valid and is included in its own COPYING file as %doc + Package xorg-x11-drv-libinput-0.1.2-1.fc22.x86_64 => Provides: libinput_drv.so()(64bit) xorg-x11-drv-libinput = 0.1.2-1.fc22 xorg-x11-drv-libinput(x86-64) = 0.1.2-1.fc22 Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) libc.so.6(GLIBC_2.7)(64bit) libinput.so.3()(64bit) rtld(GNU_HASH) Suggestions: 1) for upstream: fedora-review said AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: xf86-input-libinput-xf86-input- libinput-0.1.2/configure.ac:38 good to ask upstream to fix this. 2) Group tag is now optional and you can drop this for Fedora. 3) You may want to fix empty characters in first line of %prep 4) all install or cp commands should preserve timestamp http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps Please fix above issues before package import. APPROVED. Thanks Parag. All fixed locally and upstream as requested. New Package SCM Request ======================= Package Name: xorg-x11-drv-libinput Short Description: Xorg X11 libinput input driver Upstream URL: https://github.com/whot/xf86-input-libinput Owners: whot jwrdegoede Branches: F21 InitialCC: xgl-maint Git done (by process-git-requests). Imported and built. Thanks everyone! |