Bug 1113539
| Summary: | Always reevaluate filters before creating a PV - do not rely on a persistent filter which may contain old info | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Peter Rajnoha <prajnoha> |
| Component: | lvm2 | Assignee: | Peter Rajnoha <prajnoha> |
| lvm2 sub component: | Devices, Filtering and Stacking (RHEL6) | QA Contact: | Cluster QE <mspqa-list> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | high | ||
| Priority: | medium | CC: | agk, cmarthal, heinzm, jbrassow, msnitzer, nperic, prajnoha, prockai, zkabelac |
| Version: | 6.6 | ||
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | lvm2-2.02.108-1.el6 | Doc Type: | Bug Fix |
| Doc Text: |
Cause:
If persistent filter was used (/etc/lvm/cache/.cache) and if we created a new PV, filters were not reevaluated to pick up any changes that may have correctly prevented the PV create process to succeed.
Consequence:
LVM saw the state of the device as it was during last time LVM evaluated filters and wrote out the persistent filter. However, the device may have changed since then outside LVM which caused LVM to not take into account these changes while creating a new PV - these are changes like adding a partition table to disk or device having a new signature that prevents the device to be used as LVM PV. Without up-to-date information, LVM may end up overwriting existing foreign signatures.
Fix:
Filters are now always reevaluated before PV creation.
Result:
If there was any change done outside LVM after last filter evaluation in LVM, these changes are now properly considered before PV creation. This can prevent LVM overwriting existing foreign signatures.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-14 08:25:19 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Rajnoha
2014-06-26 11:32:39 UTC
There is one regression that the patch mentioned in comment #0 caused. There's a bug #1120564 to cover that (it's about wrong .cache file generated after vgcreate VG PV where the PV is created together with the VG and obtain_device_list_from_udev=0 and so the .cache is used). To QA: A simple reproducer may be: - make sure you have obtain_device_list_from_udev=0 in lvm.conf # vgscan Reading all physical volumes. This may take a while... Found volume group "fedora" using metadata type lvm2 # grep sda /etc/lvm/cache/.cache "/dev/sda", # parted /dev/sda mklabel gpt Information: You may need to update /etc/fstab. Before the fix: (/dev/sda still in .cache as usable device!) # grep sda /etc/lvm/cache/.cache "/dev/sda", (pvcreate not noticing /dev/sda is parted!) # pvcreate /dev/sda Physical volume "/dev/sda" successfully created With the fix: (/dev/sda still in .cache as usable device - .cache is not update until lvm command is run!) # grep sda /etc/lvm/cache/.cache "/dev/sda", # pvcreate /dev/sda Device /dev/sda not found (or ignored by filtering). # pvcreate /dev/sda -vvvv 2>&1 | grep sda | grep signature #filters/filter-partitioned.c:45 /dev/sda: Skipping: Partition table signature found Changed the partitioning on an already partitioned device, which caused the LVM to ignore the PV as expected (since 'obtain_device_list_from_udev' was off) [root@tardis-01 ~]# grep sd /etc/lvm/cache/.cache "/dev/sda1", "/dev/sdb1", "/dev/sdc1", "/dev/sdg1", "/dev/sdd1", "/dev/sde1", "/dev/sdf1", "/dev/sdh1", "/dev/sdi1", "/dev/sdj1", "/dev/sdk1", "/dev/sda2", [root@tardis-01 ~]# parted /dev/sdc mklabel gpt Warning: The existing disk label on /dev/sdc will be destroyed and all data on this disk will be lost. Do you want to continue? Yes/No? Yes Information: You may need to update /etc/fstab. [root@tardis-01 ~]# grep sd /etc/lvm/cache/.cache "/dev/sda1", "/dev/sdb1", "/dev/sdc1", "/dev/sdg1", "/dev/sdd1", "/dev/sde1", "/dev/sdf1", "/dev/sdh1", "/dev/sdi1", "/dev/sdj1", "/dev/sdk1", "/dev/sda2", [root@tardis-01 ~]# pvcreate /dev/sdc Physical volume /dev/sdc not found Device /dev/sdc not found (or ignored by filtering). marking VERIFIED with: lvm2-2.02.108-1.el6 BUILT: Thu Jul 24 17:29:50 CEST 2014 lvm2-libs-2.02.108-1.el6 BUILT: Thu Jul 24 17:29:50 CEST 2014 lvm2-cluster-2.02.108-1.el6 BUILT: Thu Jul 24 17:29:50 CEST 2014 udev-147-2.56.el6 BUILT: Fri Jul 11 16:53:07 CEST 2014 device-mapper-1.02.87-1.el6 BUILT: Thu Jul 24 17:29:50 CEST 2014 device-mapper-libs-1.02.87-1.el6 BUILT: Thu Jul 24 17:29:50 CEST 2014 device-mapper-event-1.02.87-1.el6 BUILT: Thu Jul 24 17:29:50 CEST 2014 device-mapper-event-libs-1.02.87-1.el6 BUILT: Thu Jul 24 17:29:50 CEST 2014 device-mapper-persistent-data-0.3.2-1.el6 BUILT: Fri Apr 4 15:43:06 CEST 2014 cmirror-2.02.108-1.el6 BUILT: Thu Jul 24 17:29:50 CEST 2014 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-1387.html |