Bug 1113591
Summary: | Blank space around value of rhq.server.email.smtp-host property in rhq-server.properties is not removed and causes java.net.UnknownHostException when starting JBoss ON | ||
---|---|---|---|
Product: | [JBoss] JBoss Operations Network | Reporter: | bkramer <bkramer> |
Component: | Core Server | Assignee: | Libor Zoubek <lzoubek> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Filip Brychta <fbrychta> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | JON 3.2.1 | CC: | bkramer, fbrychta, loleary, lzoubek, theute |
Target Milestone: | ER02 | ||
Target Release: | JON 3.3.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: |
Whitespace present in the rhq.erver.email.smtp-host property value in rhq-server.properties caused a java.net.UnknownHostException when JBoss ON was started. The fix adds a check to the rhqctl start and install commands that print warnings in case the tool finds lines with trailing spaces in rhq-server.properties file.
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2014-12-11 14:01:52 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1113593 |
Comment 2
bkramer
2014-06-26 14:21:18 UTC
we're supplying rhq-server.properties file to underlying EAP (via -P parameter). rhq-server.properties should be a regular java properties file (see http://docs.oracle.com/cd/E23095_01/Platform.93/ATGProgGuide/html/s0204propertiesfileformat01.html) "White space at the beginning of the line is also ignored." "The property value is generally terminated by the end of the line. White space following the property value is not ignored, and is treated as part of the property value." I think this one could be closed as NOTABUG. If you insist on fixing it anyway (which I think is not a good idea in general) we have several ways. - fix it in EAP (to trim trailing spaces when reading property files) - somehow cleanup property file ourself (probably in rhqctl) prior starting server (In reply to Libor Zoubek from comment #3) > we're supplying rhq-server.properties file to underlying EAP (via -P > parameter). rhq-server.properties should be a regular java properties file > (see > http://docs.oracle.com/cd/E23095_01/Platform.93/ATGProgGuide/html/ > s0204propertiesfileformat01.html) > > "White space at the beginning of the line is also ignored." > > "The property value is generally terminated by the end of the line. White > space following the property value is not ignored, and is treated as part of > the property value." > > I think this one could be closed as NOTABUG. If you insist on fixing it > anyway (which I think is not a good idea in general) we have several ways. > > - fix it in EAP (to trim trailing spaces when reading property files) > - somehow cleanup property file ourself (probably in rhqctl) prior starting > server Libor, I still think that we should check the property file and remove any white space around property values. It is very easy to make this mistake but the log file and messages logged there do not show clearly where the problem is and what user should do to fix it. in 3.3 branch commit e84427436990ff8229e9c6c66043f19046412ad1 Author: Libor Zoubek <lzoubek> Date: Mon Aug 18 15:56:46 2014 +0200 Bug 1113593 - Blank space around value of rhq.server.email.smtp-host property in rhq-server.properties is not removed and causes java.net.UnknownHostException when starting RHQ server Added a check to rhqctl start & install commands that prints warnings in case it finds lines with trailing spaces in rhq-server.properties file (cherry picked from commit 8b3c5958208ab48b9a7c63e90824aa43a8b76958) Signed-off-by: Libor Zoubek <lzoubek> Moving to ON_QA as available to test in the following brew build: https://brewweb.devel.redhat.com//buildinfo?buildID=379025 There is no warning visible. It seems this commit didn't make it to ER01 It didn't Moving to ON_QA as available for test with the following brew build: https://brewweb.devel.redhat.com//buildinfo?buildID=381194 Verified on Version : 3.3.0.ER02 Build Number : 4fbb183:7da54e2 Warnings are thrown to console |