Bug 1114015

Description of problem:
=======================

When a snapshot config values are changed than we are currently warning a user that it might delete the already created snapshots if they exceed the new limit. This is not a correct behaviour we are not deleting snapshots with the change in config.

[root@snapshot13 ~]# gluster snapshot list
snap3
snap4
test
test1
[root@snapshot13 ~]# gluster snapshot config snap-max-hard-limit 3
Changing snapshot-max-hard-limit will lead to deletion of snapshots if they exceed the new limit.
Do you want to continue? (y/n) y
snapshot config: System for snap-max-hard-limit set successfully
[root@snapshot13 ~]# gluster snapshot list
snap3
snap4
test
test1
[root@snapshot13 ~]# gluster snapshot config 

Snapshot System Configuration:
snap-max-hard-limit : 3
snap-max-soft-limit : 20%
auto-delete : disable

Snapshot Volume Configuration:

Volume : vol0
snap-max-hard-limit : 256
Effective snap-max-hard-limit : 3
Effective snap-max-soft-limit : 0 (20%)

Volume : vol2
snap-max-hard-limit : 256
Effective snap-max-hard-limit : 3
Effective snap-max-soft-limit : 0 (20%)

Volume : vol4
snap-max-hard-limit : 256
Effective snap-max-hard-limit : 3
Effective snap-max-soft-limit : 0 (20%)
[root@snapshot13 ~]# 



Version-Release number of selected component (if applicable):
=============================================================

glusterfs-3.6.0.22-1.el6rhs.x86_64



How reproducible:
=================
1/1


Steps to Reproduce:
===================
1. Change a config value to lesser than already created snaps


Actual results:
===============
[root@snapshot13 ~]# gluster snapshot config snap-max-hard-limit 3
Changing snapshot-max-hard-limit will lead to deletion of snapshots if they exceed the new limit.
Do you want to continue? (y/n) y
snapshot config: System for snap-max-hard-limit set successfully
[root@snapshot13 ~]#


Expected results:
=================
It should not warn a user because it doesn't actually delete the snaps