Bug 1114403

Summary: [SNAPSHOT]: On attaching a new node to the cluster while snapshot create was in progress , one of the snapshots failed with "glusterd quorum not met"
Product: [Community] GlusterFS Reporter: Joseph Elwin Fernandes <josferna>
Component: glusterdAssignee: Joseph Elwin Fernandes <josferna>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: mainlineCC: bugs, gluster-bugs, sankarshan, senaik
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: SNAPSHOT
Fixed In Version: glusterfs-3.6.0beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1112250 Environment:
Last Closed: 2014-11-11 08:36:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1112250    
Bug Blocks:    

Comment 1 Joseph Elwin Fernandes 2014-06-30 02:37:22 UTC
1) Couldn't reproduce the issue by issuing snapshot create and peer probe from the same host simultaneously
2) But was able to reproduce the issue by issuing snapshot create and peer probe from different host simultaneously. 
3) The cause for this issue is , During any snapshot operation the glusterd quorum is checked for total peer list of the node. This is not necessary as glusterd quorum should be check for the list of nodes that where chosen for this operation.
 In  glusterd_mgmt_v3_initiate_snap_phases(), As a preparation, before the 3 phases(pre-validate,commit and post-validate), a transaction list is prepared in this->private->xaction_peers. This list of peers will be participating in the operation, through-out the 3 phases. During a operation, the glusterd quorum should be checked only for these peers, as the checking of the quorum is w.r.t this current operation.

4) Fix: During a snapshot operation, glusterd quorum will be checked only for the 
transaction peers list.

Comment 2 Anand Avati 2014-06-30 02:45:23 UTC
REVIEW: http://review.gluster.org/8200 (glusterd/snapshot: fixing glusterd quorum during snap operation) posted (#1) for review on master by Joseph Fernandes (josferna)

Comment 3 Anand Avati 2014-07-01 09:47:58 UTC
REVIEW: http://review.gluster.org/8200 (glusterd/snapshot: fixing glusterd quorum during snap operation) posted (#2) for review on master by Joseph Fernandes (josferna)

Comment 4 Anand Avati 2014-07-01 10:33:31 UTC
REVIEW: http://review.gluster.org/8200 (glusterd/snapshot: fixing glusterd quorum during snap operation) posted (#3) for review on master by Joseph Fernandes (josferna)

Comment 5 Anand Avati 2014-07-03 05:12:31 UTC
REVIEW: http://review.gluster.org/8200 (glusterd/snapshot: fixing glusterd quorum during snap operation) posted (#4) for review on master by Joseph Fernandes (josferna)

Comment 6 Anand Avati 2014-07-03 08:27:55 UTC
REVIEW: http://review.gluster.org/8200 (glusterd/snapshot: fixing glusterd quorum during snap operation) posted (#5) for review on master by Joseph Fernandes (josferna)

Comment 7 Anand Avati 2014-07-04 08:27:33 UTC
COMMIT: http://review.gluster.org/8200 committed in master by Kaushal M (kaushal) 
------
commit 9a50211cdb3d6decac140a31a035bd6e145f5f2f
Author: Joseph Fernandes <josferna>
Date:   Mon Jun 30 08:07:36 2014 +0530

    glusterd/snapshot: fixing glusterd quorum during snap operation
    
    During a snapshot operation, glusterd quorum will be checked only
    on transaction peers, which are selected in the begin of the
    operation, and not on the entire peer list which is susceptible
    for change for any peer attach operation.
    
    Change-Id: I089e3262cb45bc1ea4a3cef48408a9039d3fbdb9
    BUG: 1114403
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/8200
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Kaushal M <kaushal>
    Tested-by: Kaushal M <kaushal>

Comment 8 Niels de Vos 2014-07-13 11:35:44 UTC
*** Bug 1115806 has been marked as a duplicate of this bug. ***

Comment 9 Niels de Vos 2014-09-22 12:44:07 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 10 Niels de Vos 2014-11-11 08:36:18 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users