Bug 1115386

Summary: Cloning app adds a stray space to environment variable values
Product: OpenShift Online Reporter: Dominic Cleal <dcleal>
Component: ocAssignee: Fabiano Franz <ffranz>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 2.xCC: ffranz, jokerman, mmccomas, wjiang
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-15 10:31:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dominic Cleal 2014-07-02 09:22:49 UTC
Description of problem:
When cloning an application, all environment variables get a space appended to their values.  This causes problems with passwords etc.

Version-Release number of selected component (if applicable):
rhc (1.26.9)

How reproducible:
Always

Steps to Reproduce:
1. rhc app create diy diy-0.1
2. rhc env set EMAIL_PASSWORD=foo -a diy
3. rhc ssh diy 'echo a${EMAIL_PASSWORD}a'
4. rhc create-app diy2 --from-app diy
5. rhc ssh diy2 'echo a${EMAIL_PASSWORD}a'

Actual results:
(3) prints:
"afooa"

(5) prints:
"afooa "

Expected results:
Both print "afooa"

Comment 1 Dominic Cleal 2014-07-02 09:25:39 UTC
https://github.com/openshift/rhc/pull/616

Comment 2 Fabiano Franz 2014-07-02 23:49:54 UTC
Fixed in https://github.com/openshift/rhc/pull/616

Comment 3 openshift-github-bot 2014-07-03 00:57:14 UTC
Commit pushed to master at https://github.com/openshift/rhc

https://github.com/openshift/rhc/commit/9343d512df88a8f2dd0125deb42d58ec84d700f1
Bug 1115386 - remove stray space from cloned app environment variables

Comment 4 weiwei jiang 2014-07-04 02:26:13 UTC
Checked with rhc-1.27.2 on INT(devenv_4938), and can not reproduce this issue, so verify this.