| Summary: | Review Request: nodejs-base64-js - Base64 encoding/decoding in pure JS | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-22 18:20:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1115702 | ||
|
Description
Ralph Bean
2014-07-02 21:02:54 UTC
Review: + mock build is successful for f22 - rpmlint output on rpms gave nodejs-base64-js.src: W: invalid-url URL: https://www.npmjs.org/package/base64-js <urlopen error [Errno -2] Name or service not known> nodejs-base64-js.src: W: invalid-url Source0: http://registry.npmjs.org/base64-js/-/base64-js-0.0.7.tgz <urlopen error [Errno -2] Name or service not known> nodejs-base64-js.x86_64: W: invalid-url URL: https://www.npmjs.org/package/base64-js <urlopen error [Errno -2] Name or service not known> nodejs-base64-js.x86_64: E: no-binary nodejs-base64-js.x86_64: W: only-non-binary-in-usr-lib nodejs-base64-js-debuginfo.x86_64: W: invalid-url URL: https://www.npmjs.org/package/base64-js <urlopen error [Errno -2] Name or service not known> nodejs-base64-js-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 5 warnings. ==> See suggestion below + Source verified with upstream as (sha256sum) srpm tarball :dc7c93b9932956dffa33960b55d2d5b3692864f0d1121a940cfe5d11a4bdf76c upstream tarball :dc7c93b9932956dffa33960b55d2d5b3692864f0d1121a940cfe5d11a4bdf76c + License "MIT" is valid - License is NOT packaged as %doc. + rest looks following packaging guidelines Suggestions: 1) Good to add some description instead just package name 2) Add LICENSE.MIT to %doc 3) Add following to spec BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif New release should address your suggestions: Spec URL: http://threebean.org/rpm/SPECS/nodejs-base64-js.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-base64-js-0.0.7-2.fc20.src.rpm Thanks for the update. New srpm looks good. APPROVED. New Package SCM Request ======================= Package Name: nodejs-base64-js Short Description: Base64 encoding/decoding in pure JS Upstream URL: https://npmjs.org/package/base64-js Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC: Git done (by process-git-requests). nodejs-base64-js-0.0.7-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-base64-js-0.0.7-2.fc20 nodejs-base64-js-0.0.7-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-base64-js-0.0.7-2.fc19 nodejs-base64-js-0.0.7-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-base64-js-0.0.7-2.el6 Buildroot overrides have been created. nodejs-base64-js-0.0.7-2.el6 has been pushed to the Fedora EPEL 6 stable repository. nodejs-base64-js-0.0.7-2.fc20 has been pushed to the Fedora 20 stable repository. nodejs-base64-js-0.0.7-2.fc19 has been pushed to the Fedora 19 stable repository. |