Bug 1115663
| Summary: | Review Request: nodejs-clean-css - A well-tested CSS minifier | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-22 21:33:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1115673 | ||
|
Description
Ralph Bean
2014-07-02 21:03:10 UTC
Suggestions:
1) Add following to spec
BuildArch: noarch
%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif
2) Update to latest upstream
New release includes latest upstream and specifies noarch: Spec URL: http://threebean.org/rpm/SPECS/nodejs-portscanner.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-portscanner-1.0.0-2.fc20.src.rpm Looks like different links got pasted here ;-) I am picking the correct links as SPEC URL: http://threebean.org/rpm/SPECS/nodejs-clean-css.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-clean-css-2.2.8-1.fc20.src.rpm This will help for fedora-review script. Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-clean-css.noarch: W: spelling-error Summary(en_US) minifier -> magnifier nodejs-clean-css.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-clean-css.noarch: W: spelling-error %description -l en_US http -> HTTP nodejs-clean-css.noarch: W: spelling-error %description -l en_US minifying -> magnifying, indemnifying, signifying nodejs-clean-css.noarch: W: only-non-binary-in-usr-lib nodejs-clean-css.noarch: W: dangling-symlink /usr/lib/node_modules/clean-css/node_modules/commander /usr/lib/node_modules/commander nodejs-clean-css.src: W: spelling-error Summary(en_US) minifier -> magnifier nodejs-clean-css.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-clean-css.src: W: spelling-error %description -l en_US http -> HTTP nodejs-clean-css.src: W: spelling-error %description -l en_US minifying -> magnifying, indemnifying, signifying 2 packages and 0 specfiles checked; 0 errors, 10 warnings. ==> No issues + Source verified with upstream as (sha256sum) srpm tarball :81cb03b50eac92796eca26bf25a3e609c6bb099cf541c6cb51dd4d77389f394f upstream tarball :81cb03b50eac92796eca26bf25a3e609c6bb099cf541c6cb51dd4d77389f394f + License "MIT" is valid and is included in its own file as %doc + rest looks following packaging guidelines APPROVED. (In reply to Parag AN(पराग) from comment #3) > Looks like different links got pasted here ;-) > > I am picking the correct links as > > SPEC URL: http://threebean.org/rpm/SPECS/nodejs-clean-css.spec > SRPM URL: > http://threebean.org/rpm/SRPMS/nodejs-clean-css-2.2.8-1.fc20.src.rpm > > This will help for fedora-review script. That's right! Sorry about the mis-paste there.. New Package SCM Request ======================= Package Name: nodejs-clean-css Short Description: A well-tested CSS minifier Upstream URL: https://npmjs.org/package/clean-css Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC: Git done (by process-git-requests). nodejs-clean-css-2.2.8-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-clean-css-2.2.8-1.fc20 nodejs-clean-css-2.2.8-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-clean-css-2.2.8-1.fc19 Buildroot overrides created. nodejs-clean-css-2.2.8-1.fc19 has been pushed to the Fedora 19 stable repository. nodejs-clean-css-2.2.8-1.fc20 has been pushed to the Fedora 20 stable repository. |