Bug 1115666
| Summary: | Review Request: nodejs-csslint - CSSLint | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-22 19:53:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1121735 | ||
| Bug Blocks: | 956806, 1115672 | ||
|
Description
Ralph Bean
2014-07-02 21:03:34 UTC
Review:
+ mock build is successful for f22
- rpmlint output on rpms gave
nodejs-csslint.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
nodejs-csslint.x86_64: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged
nodejs-csslint.x86_64: E: no-binary
nodejs-csslint.x86_64: W: only-non-binary-in-usr-lib
nodejs-csslint.x86_64: W: no-documentation
nodejs-csslint.x86_64: E: non-executable-script /usr/lib/node_modules/csslint/cli.js 0644L /usr/bin/env
nodejs-csslint-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 3 errors, 4 warnings.
==> See suggestion below
+ Source verified with upstream as (sha256sum)
srpm tarball :615af2eb4a5955130794e409bed690b57f72a75f1d9ca06abb8eed220bc807ff
upstream tarball :615af2eb4a5955130794e409bed690b57f72a75f1d9ca06abb8eed220bc807ff
+ License "MIT" is valid and included in source file.
+ rest looks following packaging guidelines
suggestions:
1) Add following to spec
BuildArch: noarch
%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif
2) Fix the non-executable-script rpmlint error.
3) also, update to latest upstream.
Ugh, the new upstream release has a new dependency on nodejs-parserlib. New release addresses your suggestions and depends on the new nodejs-parserlib. Spec URL: http://threebean.org/rpm/SPECS/nodejs-csslint.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-csslint-0.10.0-1.fc20.src.rpm Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-csslint.noarch: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged nodejs-csslint.noarch: W: only-non-binary-in-usr-lib nodejs-csslint.noarch: W: dangling-symlink /usr/lib/node_modules/csslint/node_modules/parserlib /usr/lib/node_modules/parserlib nodejs-csslint.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged 2 packages and 0 specfiles checked; 0 errors, 4 warnings. + Source verified with upstream as (sha256sum) srpm tarball :2d3699b21e157122126cf2afe6b424abd250a19cc30fbb1983925ce12ee802bf upstream tarball :2d3699b21e157122126cf2afe6b424abd250a19cc30fbb1983925ce12ee802bf + License "MIT" is valid and included in source file. + rest looks following packaging guidelines APPROVED. New Package SCM Request ======================= Package Name: nodejs-csslint Short Description: CSSLint Upstream URL: https://npmjs.org/package/csslint Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC: Git done (by process-git-requests). nodejs-csslint-0.10.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-csslint-0.10.0-1.fc20 nodejs-csslint-0.10.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-csslint-0.10.0-1.fc19 Buildroot overrides created. nodejs-csslint-0.10.0-1.fc19 has been pushed to the Fedora 19 stable repository. nodejs-csslint-0.10.0-1.fc20 has been pushed to the Fedora 20 stable repository. |