Bug 1115705
Summary: | Review Request: nodejs-strip-path - Strip a path from a path | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-07-22 18:22:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ralph Bean
2014-07-02 21:10:07 UTC
Review: + mock build is successful for f22 - rpmlint output on rpms gave nodejs-strip-path.x86_64: E: no-binary nodejs-strip-path.x86_64: W: only-non-binary-in-usr-lib nodejs-strip-path.x86_64: W: no-documentation nodejs-strip-path-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 2 warnings. ==> See suggestion below + Source verified with upstream as (sha256sum) srpm tarball :0d6144dc028bac69bc16a25e5d2d70ed7caeab12e44adc4d862640c2964d17fc upstream tarball :0d6144dc028bac69bc16a25e5d2d70ed7caeab12e44adc4d862640c2964d17fc + License "MIT" is valid but not included in source files. + rest looks following packaging guidelines suggestions: 1) Add following to spec BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif New release should address your suggestions: Spec URL: http://threebean.org/rpm/SPECS/nodejs-strip-path.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-strip-path-0.1.1-2.fc20.src.rpm Thanks for the update. New srpm looks good. APPROVED. New Package SCM Request ======================= Package Name: nodejs-strip-path Short Description: Strip a path from a path Upstream URL: https://npmjs.org/package/strip-path Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC: Git done (by process-git-requests). nodejs-strip-path-0.1.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-strip-path-0.1.1-2.fc20 nodejs-strip-path-0.1.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-strip-path-0.1.1-2.fc19 Buildroot overrides have been created. nodejs-strip-path-0.1.1-2.fc19 has been pushed to the Fedora 19 stable repository. nodejs-strip-path-0.1.1-2.fc20 has been pushed to the Fedora 20 stable repository. |