Bug 1115706
| Summary: | Review Request: nodejs-vow-fs - File I/O by Vow | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-22 22:33:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1115707 | ||
| Bug Blocks: | 956806, 1115665, 1115680 | ||
|
Description
Ralph Bean
2014-07-02 21:10:14 UTC
suggestions:
1) Add following to spec
BuildArch: noarch
%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif
New release should address your suggestions: Spec URL: http://threebean.org/rpm/SPECS/nodejs-vow-fs.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-vow-fs-0.3.2-2.fc20.src.rpm Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-vow-fs.noarch: W: spelling-error %description -l en_US https -> HTTP nodejs-vow-fs.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish nodejs-vow-fs.noarch: W: spelling-error %description -l en_US dfilatov -> dilator nodejs-vow-fs.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-vow-fs.noarch: W: only-non-binary-in-usr-lib nodejs-vow-fs.noarch: W: dangling-symlink /usr/lib/node_modules/vow-fs/node_modules/node-uuid /usr/lib/node_modules/node-uuid nodejs-vow-fs.noarch: W: dangling-symlink /usr/lib/node_modules/vow-fs/node_modules/vow /usr/lib/node_modules/vow nodejs-vow-fs.noarch: W: dangling-symlink /usr/lib/node_modules/vow-fs/node_modules/glob /usr/lib/node_modules/glob nodejs-vow-fs.noarch: W: dangling-symlink /usr/lib/node_modules/vow-fs/node_modules/vow-queue /usr/lib/node_modules/vow-queue nodejs-vow-fs.src: W: spelling-error %description -l en_US https -> HTTP nodejs-vow-fs.src: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish nodejs-vow-fs.src: W: spelling-error %description -l en_US dfilatov -> dilator nodejs-vow-fs.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 13 warnings. => No issues + Source verified with upstream as (sha256sum) srpm tarball :390dafb9663da553a69fb9187b14938132296771f5a056b5bb606b51e6a674ed upstream tarball :390dafb9663da553a69fb9187b14938132296771f5a056b5bb606b51e6a674ed - License tag looks not correct. License tag should be "MIT and GPLv3+" + rest looks following packaging guidelines Suggestions: 1) Fix the license tag APPROVED. New Package SCM Request ======================= Package Name: nodejs-vow-fs Short Description: File I/O by Vow Upstream URL: https://npmjs.org/package/vow-fs Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC: Git done (by process-git-requests). nodejs-vow-fs-0.3.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-vow-fs-0.3.2-2.fc20 nodejs-vow-fs-0.3.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-vow-fs-0.3.2-2.fc19 Buildroot overrides created. nodejs-vow-fs-0.3.2-2.fc20 has been pushed to the Fedora 20 stable repository. nodejs-vow-fs-0.3.2-2.fc19 has been pushed to the Fedora 19 stable repository. |