Bug 1115707
| Summary: | Review Request: nodejs-vow-queue - Vow-based task queue | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-22 19:53:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1115706 | ||
|
Description
Ralph Bean
2014-07-02 21:10:22 UTC
Review:
+ mock build is successful for f22
- rpmlint output on rpms gave
nodejs-vow-queue.x86_64: E: no-binary
nodejs-vow-queue.x86_64: W: only-non-binary-in-usr-lib
nodejs-vow-queue.x86_64: W: dangling-symlink /usr/lib/node_modules/vow-queue/node_modules/vow /usr/lib/node_modules/vow
nodejs-vow-queue-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 2 warnings.
==> See below suggestion for debuginfo
+ Source verified with upstream as (sha256sum)
srpm tarball :2104d077ef9b98a7f532c7174d931d34c33ad6c33e08858e164891e7cca189cd
upstream tarball :2104d077ef9b98a7f532c7174d931d34c33ad6c33e08858e164891e7cca189cd
- License tag is not complete.
suggestions:
1) As per source file License is dual. That is license tag should be "MIT and GPLv3+". Also, please clarify upstream this and ask them to provide which GPL version they really intend this code.
2) Add following to spec
BuildArch: noarch
%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif
New release should address your suggestions. Spec URL: http://threebean.org/rpm/SPECS/nodejs-vow-queue.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-vow-queue-0.3.1-2.fc20.src.rpm Thanks for the update. New srpm looks good. APPROVED. New Package SCM Request ======================= Package Name: nodejs-vow-queue Short Description: Vow-based task queue Upstream URL: https://npmjs.org/package/vow-queue Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC: Git done (by process-git-requests). nodejs-vow-queue-0.3.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-vow-queue-0.3.1-2.fc20 nodejs-vow-queue-0.3.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-vow-queue-0.3.1-2.fc19 Buildroot overrides created. nodejs-vow-queue-0.3.1-2.fc19 has been pushed to the Fedora 19 stable repository. nodejs-vow-queue-0.3.1-2.fc20 has been pushed to the Fedora 20 stable repository. |