Bug 1115709
| Summary: | Review Request: nodejs-w3cjs - A node.js module for using the w3c validator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-w3cjs-0.1.25-3.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-09-08 20:31:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1122244 | ||
| Bug Blocks: | 956806, 1115676 | ||
|
Description
Ralph Bean
2014-07-02 21:10:35 UTC
Review:
+ mock build is successful for f22
- rpmlint output on rpms gave
nodejs-w3cjs.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-w3cjs.src: W: spelling-error Summary(en_US) validator -> lavatorial
nodejs-w3cjs.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-w3cjs.src: W: spelling-error %description -l en_US url's -> curl's, purl's, hurl's
nodejs-w3cjs.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
nodejs-w3cjs.src: W: spelling-error %description -l en_US validator -> lavatorial
nodejs-w3cjs.x86_64: W: spelling-error Summary(en_US) js -> dis, ks, j
nodejs-w3cjs.x86_64: W: spelling-error Summary(en_US) validator -> lavatorial
nodejs-w3cjs.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-w3cjs.x86_64: W: spelling-error %description -l en_US url's -> curl's, purl's, hurl's
nodejs-w3cjs.x86_64: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
nodejs-w3cjs.x86_64: W: spelling-error %description -l en_US validator -> lavatorial
nodejs-w3cjs.x86_64: E: no-binary
nodejs-w3cjs.x86_64: W: only-non-binary-in-usr-lib
nodejs-w3cjs.x86_64: W: dangling-symlink /usr/lib/node_modules/w3cjs/node_modules/argparse /usr/lib/node_modules/argparse
nodejs-w3cjs.x86_64: W: dangling-symlink /usr/lib/node_modules/w3cjs/node_modules/superagent /usr/lib/node_modules/superagent
nodejs-w3cjs-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 15 warnings.
==> See suggestion below
+ Source verified with upstream as (sha256sum)
srpm tarball :172553bbbc2f1ce5c24d46a926f311de9d8058eddc7f716b8da046fc4a6193e2
upstream tarball :172553bbbc2f1ce5c24d46a926f311de9d8058eddc7f716b8da046fc4a6193e2
+ License "Public Domain" is valid and is included in its own file as %doc.
+ rest looks following packaging guidelines
Suggestions:
1) Update to latest upstream 0.1.25
2) Add following to spec
BuildArch: noarch
%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif
New release should address your suggestions: Spec URL: http://threebean.org/rpm/SPECS/nodejs-w3cjs.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-w3cjs-0.1.25-1.fc20.src.rpm Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-w3cjs.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-w3cjs.noarch: W: spelling-error Summary(en_US) validator -> lavatorial nodejs-w3cjs.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-w3cjs.noarch: W: spelling-error %description -l en_US url's -> curl's, purl's, hurl's nodejs-w3cjs.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml nodejs-w3cjs.noarch: W: spelling-error %description -l en_US validator -> lavatorial nodejs-w3cjs.noarch: W: only-non-binary-in-usr-lib nodejs-w3cjs.noarch: W: dangling-symlink /usr/lib/node_modules/w3cjs/node_modules/argparse /usr/lib/node_modules/argparse nodejs-w3cjs.noarch: W: dangling-symlink /usr/lib/node_modules/w3cjs/node_modules/superagent /usr/lib/node_modules/superagent nodejs-w3cjs.noarch: W: dangling-symlink /usr/lib/node_modules/w3cjs/node_modules/commander /usr/lib/node_modules/commander nodejs-w3cjs.noarch: W: dangling-symlink /usr/lib/node_modules/w3cjs/node_modules/superagent-proxy /usr/lib/node_modules/superagent-proxy nodejs-w3cjs.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-w3cjs.src: W: spelling-error Summary(en_US) validator -> lavatorial nodejs-w3cjs.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-w3cjs.src: W: spelling-error %description -l en_US url's -> curl's, purl's, hurl's nodejs-w3cjs.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml nodejs-w3cjs.src: W: spelling-error %description -l en_US validator -> lavatorial 2 packages and 0 specfiles checked; 0 errors, 17 warnings. + Source verified with upstream as (sha256sum) srpm tarball :cacbfdfa3e8f218279a9f011cf54a58b11de7cd741886fcf97ac067434dd4c7b upstream tarball :cacbfdfa3e8f218279a9f011cf54a58b11de7cd741886fcf97ac067434dd4c7b + License "Public Domain" is valid and is included in its own file as %doc. + rest looks following packaging guidelines Suggestions: 1) But you need to fix dependencies npm(commander) npm(superagent-proxy) I think we don't have package npm(superagent-proxy) Please fix above issue. Looks like npm(superagent-proxy) requires 39 other unpackaged dependencies. I'll work on that. APPROVED now as npm(superagent-proxy) is built in Fedora. New Package SCM Request ======================= Package Name: nodejs-w3cjs Short Description: A node.js module for using the w3c validator Upstream URL: https://npmjs.org/package/w3cjs Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: Git done (by process-git-requests). Built for rawhide. nodejs-w3cjs-0.1.25-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-w3cjs-0.1.25-1.fc21 nodejs-w3cjs-0.1.25-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-w3cjs-0.1.25-1.fc20 nodejs-w3cjs-0.1.25-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-w3cjs-0.1.25-1.fc19 Buildroot overrides created. nodejs-w3cjs-0.1.25-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-w3cjs-0.1.25-2.fc20 nodejs-w3cjs-0.1.25-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-w3cjs-0.1.25-2.fc19 nodejs-w3cjs-0.1.25-1.fc21 has been pushed to the Fedora 21 stable repository. nodejs-w3cjs-0.1.25-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-w3cjs-0.1.25-3.fc20 nodejs-w3cjs-0.1.25-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-w3cjs-0.1.25-3.fc19 nodejs-w3cjs-0.1.25-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. nodejs-w3cjs-0.1.25-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |