Bug 1115957

Summary: [engine-setup] engine-setup just to configure websocket proxy fails: Cannot get JAVA_HOME make sure supported JRE is installed
Product: [Retired] oVirt Reporter: Jiri Belka <jbelka>
Component: ovirt-engine-coreAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.5CC: gklein, iheim, jbelka, rbalakri, stirabos, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: integration
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1138800 (view as bug list) Environment:
Last Closed: 2014-10-17 12:29:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1080992, 1138800    
Attachments:
Description Flags
ovirt-engine-setup-20140703110715-fwbmar.log none

Description Jiri Belka 2014-07-03 11:57:09 UTC
Created attachment 914451 [details]
ovirt-engine-setup-20140703110715-fwbmar.log

Description of problem:

I'm trying to setup ovirt-engine-websocket-proxy on different host than engine is running. thus I don't see sense to have whole set of jboss/engine packages installed.

1. yum install ovirt-engine-setup-base ovirt-engine-websocket-proxy (see BZ1114978)
2. engine-setup

~~~
# engine-setup 
[ INFO  ] Stage: Initializing
[ INFO  ] Stage: Environment setup
          Configuration files: []
          Log file: /var/log/ovirt-engine/setup/ovirt-engine-setup-20140703110715-fwbmar.log
          Version: otopi-1.3.0_master (otopi-1.3.0-0.0.master.20140625.git6b6b75a.el6)
[ INFO  ] Stage: Environment packages setup
[ INFO  ] Stage: Programs detection
[ INFO  ] Stage: Environment setup
[ INFO  ] Stage: Environment customization
          Setup can automatically configure the firewall on this system.
          Note: automatic configuration of the firewall may overwrite current settings.
          Do you want Setup to configure the firewall? (Yes, No) [Yes]: 
[ INFO  ] iptables will be configured as firewall manager.
          Host fully qualified DNS name of this server [websocketproxy.rhev.lab.eng.brq.redhat.com]: 
[WARNING] Failed to resolve websocketproxy.rhev.lab.eng.brq.redhat.com using DNS, it can be resolved only locally
[ INFO  ] Checking for product updates...
[ INFO  ] No product updates found
          Configure WebSocket Proxy on this machine? (Yes, No) [Yes]: 
[ INFO  ] Stage: Setup validation
[ ERROR ] Failed to execute stage 'Setup validation': Cannot get JAVA_HOME make sure supported JRE is installed
[ INFO  ] Stage: Clean up
          Log file is located at /var/log/ovirt-engine/setup/ovirt-engine-setup-20140703110715-fwbmar.log
[ INFO  ] Generating answer file '/var/lib/ovirt-engine/setup/answers/20140703110727-setup.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Execution of setup failed
~~~

and now if ovirt-engine and its deps are installed:

~~~
# engine-setup 
[ INFO  ] Stage: Initializing
[ INFO  ] Stage: Environment setup
          Configuration files: ['/etc/ovirt-engine-setup.conf.d/10-packaging-jboss.conf', '/etc/ovirt-engine-setup.conf.d/10-packaging.conf']
          Log file: /var/log/ovirt-engine/setup/ovirt-engine-setup-20140703123206-7j66by.log
          Version: otopi-1.3.0_master (otopi-1.3.0-0.0.master.20140625.git6b6b75a.el6)
[ INFO  ] Stage: Environment packages setup
[ INFO  ] Stage: Programs detection
[ INFO  ] Stage: Environment setup
[ INFO  ] Stage: Environment customization
         
          --== PRODUCT OPTIONS ==--
         
          Configure Engine on this host (Yes, No) [Yes]: No
         
          --== PACKAGES ==--
         
[ INFO  ] Checking for product updates...
[ INFO  ] No product updates found
         
          --== NETWORK CONFIGURATION ==--
         
          Host fully qualified DNS name of this server [websocketproxy.rhev.lab.eng.brq.redhat.com]: 
[WARNING] Failed to resolve websocketproxy.rhev.lab.eng.brq.redhat.com using DNS, it can be resolved only locally
          Setup can automatically configure the firewall on this system.
          Note: automatic configuration of the firewall may overwrite current settings.
          Do you want Setup to configure the firewall? (Yes, No) [Yes]: 
[ INFO  ] iptables will be configured as firewall manager.
         
          --== DATABASE CONFIGURATION ==--
         
         
          --== OVIRT ENGINE CONFIGURATION ==--
         
         
          --== PKI CONFIGURATION ==--
         
         
          --== APACHE CONFIGURATION ==--
         
         
          --== SYSTEM CONFIGURATION ==--
         
          Configure WebSocket Proxy on this machine? (Yes, No) [Yes]:
~~~

This is odd, IMHO it should work like this:
- check what setup plugins are present
- inform/ask user to approve setup of available plugins
- then check plugins deps/related stuff

Version-Release number of selected component (if applicable):
ovirt-engine-setup-base-3.5.0-0.0.master.20140629172257.git0b16ed7.el6.noarch
ovirt-engine-setup-plugin-ovirt-engine-common-3.5.0-0.0.master.20140629172257.git0b16ed7.el6.noarch
ovirt-engine-setup-plugin-websocket-proxy-3.5.0-0.0.master.20140629172257.git0b16ed7.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. install ovirt-engine-setup-base-3.5.0-0.0.master.20140629172257.git0b16ed7.el6.noarch ovirt-engine-setup-plugin-ovirt-engine-common-3.5.0-0.0.master.20140629172257.git0b16ed7.el6.noarch ovirt-engine-setup-plugin-websocket-proxy-3.5.0-0.0.master.20140629172257.git0b16ed7.el6.noarch
2. run engine-setup
3.

Actual results:
failure

Expected results:
should work without whole java/jboss/engine stuff

Additional info:

stirabos@ commented:
> The JAVA_HOME issue is new, I agree with you that the whole websocket proxy 
> doesn't require it but I never try it on a system without a JVM.
> Please open another BZ for that.

Comment 1 Simone Tiraboschi 2014-07-03 16:55:00 UTC
Sorry, I'm not able to reproduce.

Installing only ovirt-engine-websocket-proxy (and its dependencies) after patch 
http://gerrit.ovirt.org/#/c/29456/ everything seams to work correctly.

On that VM, from ovirt repo, I've only:

[stirabos@f19td4 ~]$ yum list installed | grep ovirt
libgovirt.x86_64                 0.1.0-1.fc19       @updates                    
                                                    @ovirt-3.5-pre              
ovirt-engine-lib.noarch          3.5.0-0.0.master.20140629172304.git0b16ed7.fc19
                                                    @ovirt-3.5-pre              
ovirt-engine-setup-base.noarch   3.5.0-0.0.master.20140629172304.git0b16ed7.fc19
                                                    @ovirt-3.5-pre              
ovirt-engine-setup-plugin-websocket-proxy.noarch
                                                    @ovirt-3.5-pre              
ovirt-engine-websocket-proxy.noarch
                                                    @ovirt-3.5-pre              
ovirt-release35.noarch           001-0.0.alpha1     @/ovirt-release35           
[stirabos@f19td4 ~]$ 

and nothing at all about java

[stirabos@f19td4 ~]$ yum list installed | grep java
[stirabos@f19td4 ~]$ 


and setup completes correctly.

Can you please add the list of ovirt rpm on your setup?

Comment 2 Jiri Belka 2014-07-04 06:41:15 UTC
I do not verify patches but only builds. So when your patch is incorporated into new build, please change status for ON_QA for verification. Thanks.

Comment 3 Simone Tiraboschi 2014-07-04 08:44:41 UTC
Ok, patch http://gerrit.ovirt.org/#/c/29456/ seams also to solve this.

ovirt-engine-setup-plugin-ovirt-engine-common checks Java presence for product options that depends on that, ovirt-engine-websocket-proxy doesn't need Java but ovirt-engine-setup-plugin-websocket-proxy also doesn't depends from ovirt-engine-setup-plugin-ovirt-engine-common.
I think that on you test system you probably have also ovirt-engine-setup-plugin-ovirt-engine-common and so the problem. You simply don't need it as you also don't need the Java stuff or the DB stuff for the WebSocket proxy alone.

Comment 4 Jiri Belka 2014-07-15 10:10:40 UTC
Same comment as https://bugzilla.redhat.com/show_bug.cgi?id=1114978#c11

Comment 5 Jiri Belka 2014-07-16 07:14:01 UTC
Not merged probably, like BZ1114978, see there.

Comment 6 Simone Tiraboschi 2014-07-16 07:59:37 UTC
patch 29456 (http://gerrit.ovirt.org/#/c/29456/) should solve this too and it was already merged: we just need to wait for a new tagged release before changing to ON_QA, sorry for that.

Comment 7 Jiri Belka 2014-07-22 12:58:02 UTC
ok

ovirt-engine-setup-base-3.5.0-0.0.master.20140715172116.git4687dc1.el6.noarch
ovirt-engine-websocket-proxy-3.5.0-0.0.master.20140715172116.git4687dc1.el6.noarch
ovirt-engine-setup-plugin-websocket-proxy-3.5.0-0.0.master.20140715172116.git4687dc1.el6.noarch
ovirt-engine-lib-3.5.0-0.0.master.20140715172116.git4687dc1.el6.noarch

Comment 8 Sandro Bonazzola 2014-10-17 12:29:13 UTC
oVirt 3.5 has been released and should include the fix for this issue.