Bug 1116756
| Summary: | System config printer applet locks up after authenticating one print job | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andre Heinecke <aheinecke> | ||||||
| Component: | system-config-printer | Assignee: | Tim Waugh <twaugh> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 20 | CC: | aheinecke, jpazdziora, jpopelka, marcus.moeller, twaugh | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | system-config-printer-1.5.1-3.fc21 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-09-23 04:31:04 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 917378 [details]
Patch to use Gtk's main loop in the D-Bus service
Could you try this patch please, instead of the one you're using now?
It tells the jobviewer not to process pending requests, but it also now uses the Gtk main loop -- which I think might fix other similar hangs.
Hi, I've tested the 1.4.x branch installed locally on an Ubuntu 14.4. Without your patch i could reliably reproduce the hang. With your patch it worked flawlessly no more hangs. Thanks, Andre Thanks! Fixed upstream in commit f8bfb251a00f994de6c796fdb14f8996d2265991. system-config-printer-1.5.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/system-config-printer-1.5.1-1.fc21 Package system-config-printer-1.5.1-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing system-config-printer-1.5.1-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-10163/system-config-printer-1.5.1-1.fc21 then log in and leave karma (feedback). Package system-config-printer-1.5.1-2.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing system-config-printer-1.5.1-2.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-10163/system-config-printer-1.5.1-2.fc21 then log in and leave karma (feedback). Package system-config-printer-1.5.1-3.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing system-config-printer-1.5.1-3.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-10163/system-config-printer-1.5.1-3.fc21 then log in and leave karma (feedback). The problem still occurs with system-config-printer-1.5.1-3.fc21.x86_64 And there's a report of it fixing the problem for someone else: https://bugs.launchpad.net/bugs/1291075 Marcus: could it be that you are seeing some other bug? system-config-printer-1.5.1-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. Any chance of getting the fix backported to Fedora 20 as well? I tried to scratch build system-config-printer-1.5.1-3.fc21.src.rpm but the result requires python3-cups. Fedora 20 still has over nine months to live and it'd be nice to see errata for it as well. Thank you, Jan I'll try to get to that (i.e. a system-config-printer 1.4.6 release) soon. Just to make sure, this patch does not solve the problem that has been described initially. At Tim, the one you linked seems to be different from what I experience here. Hi, (In reply to Marcus Moeller from comment #13) > Just to make sure, this patch does not solve the problem that has been > described initially. At Tim, the one you linked seems to be different from > what I experience here. Marcus this patch solves the problem I described in the Original Post. I really could reproduce the freeze without it and the problem no longer existed with this patch. - Does the Hack I've attached as patch here (commenting out the Main Iteration) work for you? - Does the applet really stop responding to all user input in your case? In my test I could not even open the job queue after one Print job as it was completely frozen. If it still does not work for i think we should open a new issue and start debugging on this there. In our case, the first print job gets spooled every time. For all following print jobs, the Queue view of system-config-printer needs to be open in order to spool the jobs. They are listed for 'Held for authentication', but when you open the queue view, they are spooled directly. Marcus: it sounds like your application's print dialog isn't asking for authentication when it ought to. I am printing from GTK+3 and password is stored in keyring. Testing on Fedora 21 right now. Re-checked: it was my fault. system-config-printer-applet was not running. |
Created attachment 916002 [details] Comment out main iteration in status icon update We were trying to use system-config-printer-applet to automatically authenticate print jobs over Samba in the background. This worked nicely with the first print job but for any more jobs the applet did not show a notification and it locked up. Debugging showed that it locked up in set_statusicon_visibility in the loop: while self.process_pending_events and Gtk.events_pending (): Gtk.main_iteration () It appeared that update_status (caused by the next iteration) would block on Gdk.threads_enter (). But I failed to find where the thread lock was held in the first place. I think in this codepath process_pending_events should be false. But I am not sure why / when this should be set or not or where I should set this to false in this case. Version-Release number of selected component (if applicable): 1.4.x branch Steps to Reproduce (might be easier but this is the problem we saw): 1. Create a print job on a Printer that needs Samba authentication 2. Enter credentials and save them in gnome-keyring 3. Start another print job Actual results: No notification / job not authenticated. Clicking on the tray icon did nothing. Expected results: Job should be automatically authenticated. Attached hack solved the Problem for us with no appearent regressions caused by it.