Bug 1116854

Summary:	libgfapi: Issue with self-healing of files during glfs_resolve
Product:	[Community] GlusterFS	Reporter:	Soumya Koduri <skoduri>
Component:	libgfapi	Assignee:	Soumya Koduri <skoduri>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.5.0	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-11 08:36:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Soumya Koduri 2014-07-07 13:29:44 UTC

Description of problem:

While resolving any path during the lookup, libgfapi should generate and send gfid as well along with the new inode created to the syncop_lookup(..) so that POSIX translator can heal the files with missing gfid using the new gfid passed.

But there is an issue with the current implementation. This needs to be fixed. 

Also, incase of lookup failed (with no entry found error), that inode needs to be unlinked in gfapi as well the way its done in the fuse client layer (bug-985074).

Comment 1 Anand Avati 2014-07-07 13:40:24 UTC

REVIEW: http://review.gluster.org/7976 (libgfapi: Fixed an issue with healing files during glfs_resolve) posted (#4) for review on master by soumya k (skoduri)

Comment 2 Anand Avati 2014-07-16 11:48:27 UTC

COMMIT: http://review.gluster.org/7976 committed in master by Vijay Bellur (vbellur) 
------
commit 119109e95268061d9a68c09972302c35a1b22201
Author: Soumya Koduri <skoduri>
Date:   Wed Jun 4 18:40:00 2014 +0530

    libgfapi: Fixed an issue with healing files during glfs_resolve
    
              While resolving any path during the first lookup, libgfapi
              should generate and send gfid as well along with the new inode
              created to the syncop_lookup(..) so that POSIX translator
              can heal the files with missing gfid using the new gfid passed.
    
              This wasn't happening correctly in the current "glfs_resolve_component(..)"
              implementation. Fixed the same.
    
              Also have added the changes from http://review.gluster.org/5337 in
              libgfapi, which is a fix to unlink the inode on revalidate if entry not found.
    
              In addition to the above, have cleaned up a redundant gfapi log mesage.
    
    Change-Id: I0757dda782d16ba6bdbe7ebdbde9c43381229b0a
    BUG: 1116854
    Signed-off-by: Soumya Koduri <skoduri>
    Reviewed-on: http://review.gluster.org/7976
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Poornima G <pgurusid>
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2014-09-22 12:44:37 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 4 Niels de Vos 2014-11-11 08:36:47 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users