Bug 1117304

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/maven-poms/os-maven-plugin, /usr/share
     /maven-metadata

false positive:
$ rpm -qf /usr/share/maven-metadata/
javapackages-tools-4.1.0-1.fc21.noarch

[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/maven-poms/os-maven-
     plugin, /usr/share/maven-metadata
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It is
     pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: os-maven-plugin-1.2.3-1.fc21.noarch.rpm
          os-maven-plugin-javadoc-1.2.3-1.fc21.noarch.rpm
          os-maven-plugin-1.2.3-1.fc21.src.rpm
os-maven-plugin.noarch: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces
os-maven-plugin.src: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces
3 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint os-maven-plugin-javadoc os-maven-plugin
os-maven-plugin.noarch: W: spelling-error %description -l en_US whitespaces -> white spaces, white-spaces, whites paces
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'



Requires
--------
os-maven-plugin-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils

os-maven-plugin (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(org.apache.maven:maven-plugin-api)
    mvn(org.codehaus.plexus:plexus-utils)
    osgi(org.eclipse.core.runtime)
    osgi(org.eclipse.ui)



Provides
--------
os-maven-plugin-javadoc:
    os-maven-plugin-javadoc

os-maven-plugin:
    mvn(kr.motd.maven:os-maven-plugin)
    mvn(kr.motd.maven:os-maven-plugin:pom:)
    os-maven-plugin
    osgi(kr.motd.maven.os)



Source checksums
----------------
https://github.com/trustin/os-maven-plugin/archive/os-maven-plugin-1.2.3.Final.tar.gz :
  CHECKSUM(SHA256) this package     : 2bc4f833c4f2d01ebd4afa2c521719768800a0d6b2e212e493c935a9e369df86
  CHECKSUM(SHA256) upstream package : 2bc4f833c4f2d01ebd4afa2c521719768800a0d6b2e212e493c935a9e369df86


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1117304
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Java


Only minor things:
Requires:
    osgi(org.eclipse.core.runtime)
    osgi(org.eclipse.ui)
These probably shouldn't be there

[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/maven-poms/os-maven-
     plugin

Rest of the package looks good.

These 2 small issues can be easily fixed at import time.

APPROVED.

New Package SCM Request
=======================
Package Name: os-maven-plugin
Short Description: Maven plugin for generating platform-dependent properties
Owners: mizdebsk msimacek msrb
Branches: f20
InitialCC: java-sig

Git done (by process-git-requests).

I fixed the 2 review issues during import.
Package is built for F21 and F22.