DescriptionDouglas Schilling Landgraf
2014-07-08 14:57:56 UTC
Description of problem:
I have noticed that the code that we used to check if there is an iso update to ovirt-node host got removed. Although shouldAlertUpgrade() is still available in HostGeneralModel.java [1].
<snip>
- VDS vds = hostGeneralModel.getEntity();
- String [] hostOsInfo =
-vds.getHostOs().split("-"); //$NON-NLS-1$ //$NON-NLS-2$
- for (int counter = 0; counter <
- hostOsInfo.length; counter++) {
- hostOsInfo[counter] =
- hostOsInfo[counter].trim();
- }
- hostGeneralModel.setHasUpgradeAlert(
- shouldAlertUpgrade(
- isos,
- hostOsInfo
- )
- );
</snip>
From my investigation this happened when the code got split.
commit c20ebaee3f771ef7893f0be16f47e915d84cca80
Date: Fri Mar 7 12:06:12 2014 -0500
webadmin: host right click menu is missing 'reinstall' option
[1] https://github.com/oVirt/ovirt-engine/blob/master/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java#L651
Comment 2Douglas Schilling Landgraf
2014-09-10 17:44:44 UTC
(In reply to Petr Beňas from comment #1)
> Please provde steps to reproduce/verify.
- Install a higher version of ovirt-node (RPM) in ovirt-engine machine
After that, users should see a message sharing that there is a higher version of ovirt-node available for upgrade. Ravi, please correct me if the steps changed in the current source code.
Thanks!
Description of problem: I have noticed that the code that we used to check if there is an iso update to ovirt-node host got removed. Although shouldAlertUpgrade() is still available in HostGeneralModel.java [1]. <snip> - VDS vds = hostGeneralModel.getEntity(); - String [] hostOsInfo = -vds.getHostOs().split("-"); //$NON-NLS-1$ //$NON-NLS-2$ - for (int counter = 0; counter < - hostOsInfo.length; counter++) { - hostOsInfo[counter] = - hostOsInfo[counter].trim(); - } - hostGeneralModel.setHasUpgradeAlert( - shouldAlertUpgrade( - isos, - hostOsInfo - ) - ); </snip> From my investigation this happened when the code got split. commit c20ebaee3f771ef7893f0be16f47e915d84cca80 Date: Fri Mar 7 12:06:12 2014 -0500 webadmin: host right click menu is missing 'reinstall' option [1] https://github.com/oVirt/ovirt-engine/blob/master/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java#L651