Bug 1117407

Summary: configuring 1des and trying to bring up the connection causes a crash and restart
Product: Red Hat Enterprise Linux 6 Reporter: Paul Wouters <pwouters>
Component: openswanAssignee: Paul Wouters <pwouters>
Status: CLOSED DUPLICATE QA Contact: BaseOS QE Security Team <qe-baseos-security>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.5   
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-09-11 14:54:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Paul Wouters 2014-07-08 15:29:50 UTC
Description of problem:

configuring 1des, which is not allowed, results in an NULL proposal struct, which we can't set the parentSA for.

Program received signal SIGSEGV, Segmentation fault.
oakley_alg_makedb (ai=<optimized out>, base=base@entry=0x7facadb0ba90 <oakley_sadb+80>, maxtrans=maxtrans@entry=-1)
    at /usr/src/debug/openswan-2.6.32/programs/pluto/spdb_struct.c:316
316	    gsp->parentSA = TRUE;

The simple fix (from libreswan) is oakley_alg_makedb():

+ if (gsp != NULL)
       gsp->parentSA = TRUE;


This happens because the parser allowed "des" but the code does not allow it. The parser could also be told that "des" is not a valid keyword

Comment 1 Paul Wouters 2014-07-08 15:32:44 UTC
commit 2d0a4be2968457d58954b79b6496927cb7f157d0
Author: Paul Wouters <pwouters>
Date:   Thu May 15 15:44:01 2014 -0400

    pluto: don't die when the only loaded proposal is completely invalid

Comment 3 Paul Wouters 2014-09-11 14:54:25 UTC

*** This bug has been marked as a duplicate of bug 1114683 ***