Bug 1117466

Summary: "rhc server use" incorrectly shares configs between servers
Product: OpenShift Online Reporter: Brenton Leanhardt <bleanhar>
Component: ocAssignee: Fabiano Franz <ffranz>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2.xCC: ffranz, jokerman, mmccomas, xiuwang, xtian
Target Milestone: ---Keywords: UpcomingRelease
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-10 00:48:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Test CA that will reproduce the bug none

Description Brenton Leanhardt 2014-07-08 18:42:49 UTC 
Created attachment 916527 [details]
Test CA that will reproduce the bug

Description of problem:

Given two servers A and B configured using rhc, if A uses a custom CA and B does not use the same CA then switching from A to B will fail.

Here's how to reproduce using the attahced test CA:

~/.openshift/express.conf
libra_server=broker.example.com

---
- server:
    hostname: openshift.redhat.com
    use_authorization_tokens: true
    nickname: online
    insecure: false
    login: XXXXXX
- server:
    hostname: broker.example.com
    use_authorization_tokens: true
    nickname: ose
    ssl_ca_file: [see attached]
    insecure: false
    login: XXXXXXX

$ rhc server use online => "The server's certificate could not be verified..."

Version-Release number of selected component (if applicable):
1.26.9

Additional info:

This appears to be due to the following logic:

https://github.com/openshift/rhc/blob/master/lib/rhc/commands/server.rb#L210

'options' behaves like a global variable and is set to broker.example.com's setting when rhc starts up.  When the use command is run it then triggers this logic but the CA setting is not removed when the new setting is nil.
Comment 1 openshift-github-bot 2014-07-09 00:54:43 UTC 
Commit pushed to master at https://github.com/openshift/rhc

https://github.com/openshift/rhc/commit/0676da829522112196044a670210998805990c9b
Bug 1117466 - should not reuse SSL certs from different server configs
Comment 2 XiuJuan Wang 2014-07-09 05:15:43 UTC 
Verified on the lastest rhc build from devenv_4950

Could switch servers when they have different CA files.

---
- server:
    hostname: openshift.redhat.com
    nickname: online
    login: XXXXXXXXX
    use_authorization_tokens: true
    insecure: false
- server:
    hostname: int.openshift.redhat.com
    nickname: int
    login: XXXXXXXX
    use_authorization_tokens: true
    insecure: true
    ssl_version: SSLv3
    ssl_client_cert_file: ./cert/server.crt
    ssl_ca_file: ./root-ca.crt.pem

Mark bug as verified.
Comment 3 XiuJuan Wang 2014-07-14 06:37:09 UTC 
rhc-1.28.0 build from devenv_4962

Given two servers A and B configured using rhc, if A uses timeout parameter and B does not use the same parameter.Then switching from A to B, B will use A server's timeout value.

step 1: Server list
Server 'online' (in use)
------------------------
  Hostname:        openshift.redhat.com
  Login:           XXXXXXXXXXX
  Use Auth Tokens: true
  Insecure:        false
  Timeout:         22

Server 'stg'
------------
  Hostname:        stg.openshift.redhat.com
  Login:           XXXXXXXXXX
  Use Auth Tokens: true
  Insecure:        true

2.Switch online to stg

3.Server list, stg shares online's timeout parameter.
Server 'online'
---------------
  Hostname:        openshift.redhat.com
  Login:           xiuwang+6
  Use Auth Tokens: true
  Insecure:        false
  Timeout:         22

Server 'stg' (in use)
---------------------
  Hostname:        stg.openshift.redhat.com
  Login:           xiuwang
  Use Auth Tokens: true
  Insecure:        true
  Timeout:         22
Comment 4 Fabiano Franz 2014-07-14 14:15:35 UTC 
Timeout issue fixed in https://github.com/openshift/rhc/pull/625
Comment 5 openshift-github-bot 2014-07-14 15:55:02 UTC 
Commit pushed to master at https://github.com/openshift/rhc

https://github.com/openshift/rhc/commit/96a22b95112402476c401568cc1ba796f39ffe2e
Bug 1117466 - fixes overriding timeout config
Comment 6 XiuJuan Wang 2014-07-15 02:47:40 UTC 
rhc build from devenv_4967

Can't reproduce this issue of comment 3.

Move bug to verified. Thanks!