Bug 1117769

Summary:	Scalable app will keep using the customized haproxy_ctld.rb even the action hook has been removed from app git repo
Product:	OpenShift Online	Reporter:	Meng Bo <bmeng>
Component:	Image	Assignee:	Ben Parees <bparees>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	bperkins, jialiu, jokerman, mmccomas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1117949 (view as bug list)		Environment:
Last Closed:	2014-10-10 00:48:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1117949

Description Meng Bo 2014-07-09 11:23:52 UTC

Description of problem:
Create scalable app and add the customized haproxy_ctld.rb to the app git repo and push to server. The app will use the customized haproxy_ctld.rb for auto scaling. But after user remove the file from .openshift/action_hook and push the change to server, the gear will keep using the customized haproxy_ctld.rb, restart app cannot fix the issue.

The process of the custom haproxy_ctld will not be killed in gear.

Version-Release number of selected component (if applicable):
devenv_4951

How reproducible:
always

Steps to Reproduce:
1. Create scalable app
2. Add a custom haproxy_ctld.rb to the .openshift/action_hooks and git push
3. Remove the custom haproxy_ctld.rb and push it again

Actual results:
The app will still using the custom haproxy_ctld.rb and the process still leaves there even restart the app.

Expected results:
Should use the default haproxy_ctld.rb when user removed the custom one.

Additional info:

Comment 1 Ben Parees 2014-07-09 19:15:56 UTC

https://github.com/openshift/origin-server/pull/5586

Comment 2 Meng Bo 2014-07-10 05:31:09 UTC

Checked on devenv_4955, the issue has been fixed, after remove the action hook, it will fall back to use the cartridge default haproxy_ctld.rb for auto scaling.

But the output is a little confuse from my side, it said the action hook removed but restarted after that.

remote: HAProxy already running
remote: Action hook haproxy_ctld.rb removed
remote: Action hook haproxy_ctld.rb restarted
remote: HAProxy instance is started

@bparees Not sure if this is a typo, seems you meant to say restart w/ the normal cart haproxy_ctld.rb?

Comment 3 Ben Parees 2014-07-10 13:52:35 UTC

Yes that's a typo in the output message.

master:
https://github.com/openshift/origin-server/pull/5588
stage:
https://github.com/openshift/origin-server/pull/5590

Comment 4 Meng Bo 2014-07-11 06:22:28 UTC

remote: HAProxy already running
remote: Action hook haproxy_ctld.rb removed
remote: Cartridge haproxy_ctld.rb started
remote: HAProxy instance is started

Checked on current STG (devenv-stage_907), issue has been fixed.