Bug 1117813
Summary: | WSRP v1 - epp4.3 vs rhjp6.2.0 - Unknown error when importing applications in app registry | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [JBoss] JBoss Enterprise Portal Platform 6 | Reporter: | vramik | ||||||||||||||||
Component: | Portal | Assignee: | Nobody <nobody> | ||||||||||||||||
Status: | VERIFIED --- | QA Contact: | vramik | ||||||||||||||||
Severity: | unspecified | Docs Contact: | |||||||||||||||||
Priority: | unspecified | ||||||||||||||||||
Version: | 6.2.0 | CC: | epp-bugs, mvecera, ppalaga, theute, vramik | ||||||||||||||||
Target Milestone: | ER05 | ||||||||||||||||||
Target Release: | 6.2.0 | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Whiteboard: | |||||||||||||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||
Doc Text: | Story Points: | --- | |||||||||||||||||
Clone Of: | Environment: | ||||||||||||||||||
Last Closed: | Type: | Bug | |||||||||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||||||||
Documentation: | --- | CRM: | |||||||||||||||||
Verified Versions: | Category: | --- | |||||||||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||
Embargoed: | |||||||||||||||||||
Attachments: |
|
Description
vramik
2014-07-09 12:43:24 UTC
Created attachment 916763 [details]
jboss-image-portlet-sample-remotable-JBoss-portal.war
I couldn't reproduce this. I'm attaching the logs for ER4, from the startup till the step where I finished importing. My environment and the steps I did is as follows: - Fedora 20 - Java 8 (should not matter) - EPP 4.3.CP07 started on default port, production profile - RHJP 6.2.0.ER4 started with port-offset 100, on the same machine - Deployed the attached WAR file into EPP - Started EPP - Started RHJP - On RHJP, added consumer "epp43" with URL http://localhost:8080/portal-wsrp/MarkupService?wsdl - Application Registry - Import Applications At the end of these steps, I don't see any exceptions on the log, and I get positive confirmation that the "image portlet sample" is imported (third to last line on the log): 16:11:03,669 INFO [org.exoplatform.application.registry.impl.ApplicationRegistryServiceImpl] (http-/127.0.0.1:8180-2) Importing portlet (epp43,jboss-image-portlet-sample) in categories [epp43, epp43 Producer, remote] I went a bit further and added this remote portlet to a page, and I indeed see the picture of some of the older guys there. It would be interesting to test it on other machines and/or on clean installations of both EPP and RHJP. Created attachment 916816 [details]
logs for a successful run
Created attachment 917026 [details]
jboss-image-portlet-sample-remotable-GateIn.war
In the test scenario there is another portlet deployed in RHJP6.2.0 (jboss-image-portlet-sample-remotable-GateIn.war). The portlet causes the Unknown error. The portlet is almost the same as jboss-image-portlet-sample-remotable-JBoss-portal.war but there are some changes made for newer portal.
- added org.gatein.pc.remotable into portlet.xml
- added jboss-portlet.xml
The problem is both portlets has the same <portlet-name> in portlet.xml. The thing is that in ER03 it worked even with the same names.
So it is not probably a bug but expected change. Can you confirm, pls?
From what I could gather based on the spec, it's legal to have the same portlet-name in different portlet applications. From the spec: PLT.25.7 Uniqueness of Deployment Descriptor Values The following deployment descriptor values must be unique in the scope of the portlet application definition: * portlet <portlet-name> * ... The item above has mentioned "portlet application", which is defined as: A portlet application is a web application, as defined in Servlet Specification, SRV.9 Chapter, containing portlets and a portlet deployment descriptor in addition to servlets, JSPs, HTML pages, classes and other resources normally found in a web application. I'll try to reproduce again based on the new information. 854461feeb8bcf0eec54ef8a47fe2f02f5149966 is the first bad commit commit 854461feeb8bcf0eec54ef8a47fe2f02f5149966 Author: Lucas Ponce <lponce> Date: Mon Jun 9 10:18:02 2014 +0200 GTNPORTAL-3494 Fix for side effect in App Registry import-all :040000 040000 9ec7b609dc7805b12aa14e0cd3ad5b80ee5d24f2 941201e1209aae3d63c9c28eef629f2846aea63c M component I'll be checking how this can be fixed, without breaking the intended fix for that commit. Created attachment 917259 [details] proposed fix I'm attaching a JAR with a proposed fix. This should replace the following file: jboss-eap/modules/system/layers/gatein/org/gatein/lib/main/exo.portal.component.application-registry-*jar Please, note that the following BZs might be affected: #1107566 and #1101275 , as well as the JIRA GTNPORTAL-3494 , so, a coordination with Petr and Tomas (the reporters of those issues) for re-testing of those issues is advised. I've tested it locally on the scenario for this BZ, and it seems to work fine. I've also quickly tested for the related BZs, and couldn't reproduce any of them, so, I believe they are not badly affected. By the way, Petr Mensik confirmed that this change does *not* affect badly the related BZs (BZ#1107566 and BZ#1101275) Created attachment 917730 [details] proposed fix - updated I'm attaching a new proposed fix, that should avoid the problems discussed on the PR at github. I did a test here, and it seems to fix both this BZ and BZ#1107566, but *not* BZ#1101275 , as I believe that BZ#1101275 has a wrong premise (ie: the expected result for the name contains spaces, which are not allowed as per the validation rules). I experienced similar problem, the same exception. I created a portal application with several portlets, deployed the .war file, then in pom.xml of the portal application changed the Artifact ID, build and deployed second .war (same content, just different name). I'm getting an Unknown Error and the IllegalArgumentException during "Import Applications". Created attachment 917877 [details]
proposed fix - updated
Yet another proposal, as mgottval got hit by the "first-30 chars clash" minutes after the last message, making me wonder if this wouldn't be a common clash after all.
After some discussion with ppalaga, I've added the hashCode for the contentId to the name, so, clashes are now very unlikely to happen.
https://github.com/gatein/gatein-portal/pull/887 was merged in upstream |