Bug 1117835

Summary:	Incorrect dhcp providers server virsh.rb loadSubnetData
Product:	Red Hat Satellite	Reporter:	Bryan Kearney <bkearney>
Component:	Foreman Proxy	Assignee:	Katello Bug Bin <katello-bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Katello QA List <katello-qa-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.0.4	CC:	cwelton, jmontleo
Target Milestone:	Unspecified
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
URL:	http://projects.theforeman.org/issues/6377
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-11 12:28:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bryan Kearney 2014-07-09 13:28:26 UTC

The commit fixes dhcp server virsh.rb provider. Upon loading the
contents of the libvirt network XML and parsing for DHCP reservations a
check is performed on the kind of records that are being loaded. The
dhcp_api.rb 'delete' helper tries to load network entries of the
'reservation' kind, the helper uses modules/dhcp/dhcp/subnet.rb to
validate on that and filter out entries.

In contrary to other providers (ms, isc) the loadSubnetData method of
virsh.rb was dealing out "Proxy::DHCP::Record" for any entry it was able
to discover, but should have been instantiating
"Proxy::DHCP::Reservation" to pass the validation.

This resulted in "ERROR -- : Record
x.x.x.x/xx:xx:xx:xx:xx:xx not found" as well as leaves in the libvirt
network XML. This prevented the creation of VMs with the same addresses,
since leftover DHCP entries conflicted with the new ones.

https://github.com/theforeman/smart-proxy/pull/164

Comment 1 Bryan Kearney 2014-07-09 13:28:27 UTC

Created from redmine issue http://projects.theforeman.org/issues/6377

Comment 3 Bryan Kearney 2014-07-09 13:47:42 UTC

Moving to POST since upstream bug http://projects.theforeman.org/issues/6377 has been closed
-------------
Anonymous
Applied in changeset commit:1fb2109b4adf617bcd24919463d8e665edee97e4.

Comment 5 Bryan Kearney 2014-09-11 12:28:46 UTC

This was delivered with Satellite 6.0 which was released on 10 September 2014.