Bug 1118289 (Horde_Service_Gravatar)
| Summary: | Review Request: php-horde-Horde-Service-Gravatar - php-horde-Horde-Service-Gravatar | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-horde-Horde-Service-Gravatar-1.0.0-1.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-08-01 06:00:22 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Remi Collet
2014-07-10 11:44:53 UTC
I will clean EL-5 stuff after import. This is a new optional dependency of Horde / Nag / Turba / Kronolith I prefer to keep CamelCase name for consistency with other horde packages. I will clean EL-5 stuff after import. This is a new optional dependency of Imp I prefer to keep CamelCase name for consistency with other horde packages. Created attachment 919731 [details]
fedora-review.txt
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1118289
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Created attachment 919732 [details]
phpcompatinfo.log
phpcompatinfo version 2.26.0
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
As usual, just remove these EPEL 5 bits after initial import
No blockers.
===== APPROVED =====
Thanks for the review ! New Package SCM Request ======================= Package Name: php-horde-Horde-Service-Gravatar Short Description: php-horde-Horde-Service-Gravatar Upstream URL: http://www.horde.org/ Owners: remi Branches: f20 f21 el6 epel7 InitialCC: Git done (by process-git-requests). php-horde-Horde-Service-Gravatar-1.0.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Service-Gravatar-1.0.0-1.el6 php-horde-Horde-Service-Gravatar-1.0.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-horde-Horde-Service-Gravatar-1.0.0-1.fc20 php-horde-Horde-Service-Gravatar-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. php-horde-Horde-Service-Gravatar-1.0.0-1.fc20 has been pushed to the Fedora 20 stable repository. php-horde-Horde-Service-Gravatar-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |