Bug 1118528 (php-twig)
| Summary: | Review Request: php-twig - The flexible, fast, and secure template engine for PHP | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora, package-review | ||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | php-twig-1.16.0-2.fc21 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-09-09 22:11:30 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Shawn Iwinski
2014-07-11 00:47:42 UTC
Scratch builds: * rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=7126666 * f21: https://koji.fedoraproject.org/koji/taskinfo?taskID=7126671 * f20: https://koji.fedoraproject.org/koji/taskinfo?taskID=7126675 * el7: https://koji.fedoraproject.org/koji/taskinfo?taskID=7126679 * el6: https://koji.fedoraproject.org/koji/taskinfo?taskID=7126682 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/b68f8c90465a4c4f1c132d2c7803b3d619e7ace8/php-twig.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-twig-1.16.0-1.fc20.src.rpm Name change from php-ctwig to php-twig and provides both lib and extension in single pkg. Created attachment 929930 [details]
review.txt
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Sorry but this is in the MUST list...
[!]: Changelog in prescribed format.
Bad date Fri Jul 29 2014: should be Tue Jul 29 2014
Simple... but blocker...
Should (you can disagree ;):
=> I agree with making the test optional (as they are enabled by default). But I think the "minimal load test" should be always execute (so outside the %if)
Obsoletes: php-twig-CTwig < %{version}-%{release}
Provides: php-twig-CTwig = %{version}-%{release}
=> this can probably be dropped (php-twig-CTwig was never imported in Fedora)
Optional dependency: Xdebug (php-pecl-xdebug)
=> this doesn't give any new feature, the code only check if present for some output. I think this comment can be removed
=> this package obsoletes all packages in the twig channel, so should also obsoletes php-channel-twig (which could then be removed from F21+ repo)
Else everything is fine.
Changes: https://github.com/siwinski/rpms/commit/afff11887c588242727bd86089fd570e29dc713c Spec URL: https://raw.githubusercontent.com/siwinski/rpms/afff11887c588242727bd86089fd570e29dc713c/php-twig.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-twig-1.16.0-2.fc20.src.rpm All changes ok. No blocker ==== APPROVED ==== THANKS for the review! New Package SCM Request ======================= Package Name: php-twig Short Description: The flexible, fast, and secure template engine for PHP Upstream URL: http://twig.sensiolabs.org Owners: siwinski remi Branches: f20 f21 epel7 InitialCC: Git done (by process-git-requests). php-twig-1.16.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-twig-1.16.0-2.fc20 php-twig-1.16.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-twig-1.16.0-2.fc21 php-twig-1.16.0-2.fc20 has been pushed to the Fedora 20 testing repository. php-twig-1.16.0-2.fc20 has been pushed to the Fedora 20 stable repository. php-twig-1.16.0-2.fc21 has been pushed to the Fedora 21 stable repository. Package Change Request ====================== Package Name: php-twig New Branches: el6 Owners: siwinski remi InitialCC: Git done (by process-git-requests). |