|Summary:||DHT : If Directory creation is in progress and rename of that Directory comes from another mount point then after both operation few files are not accessible and not listed on mount and more than one Directory have same gfid|
|Product:||Red Hat Gluster Storage||Reporter:||Rachana Patel <racpatel>|
|Component:||distribute||Assignee:||Raghavendra G <rgowdapp>|
|Status:||CLOSED ERRATA||QA Contact:||Prasad Desala <tdesala>|
|Version:||rhgs-3.0||CC:||amukherj, avasudev, bmohanra, nbalacha, nchilaka, rcyriac, rgowdapp, rhinduja, sankarshan, sheggodu, smohan, spalai, srmukher|
|Target Release:||RHGS 3.4.0|
|Whiteboard:||triaged,hotfix, dht-directory-consistency, dht-3.2.0-proposed, rebase|
|Fixed In Version:||glusterfs-3.12.2-1||Doc Type:||Bug Fix|
Previously, rename and lookup option were not synchronized. The source gfid was not always associated with destination path once rename is complete and hence contents of the directories were not visible. This resulted in the creation of different directories with the same gfid.
|:||1252244 1328473 (view as bug list)||Environment:|
|Last Closed:||2018-09-04 06:26:56 UTC||Type:||Bug|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Cloudforms Team:||---||Target Upstream Version:|
|Bug Depends On:||1369312|
|Bug Blocks:||1118762, 1252244, 1311843, 1324381, 1336698, 1337022, 1337394, 1345828, 1503134|
Description Rachana Patel 2014-07-11 13:43:26 UTC
Description of problem: ======================= Create Directory from mountpoint and while creation is in progress (Directory created only on hashed sub-volume), execute rename of that Directory(destination Directory does not exist and both Source and Destination hash to same sub-volume here) i.e. from one mout point :- mkfir dir1 from another mount point mv dir1 dir2 After both operation are finished:- - same gfid for different Directories (at same level) - sometimes few files inside those directories are not listed on mount and not accessible Version-Release number : ========================= 22.214.171.124-1.el6rhs.x86_64 How reproducible: ================= always Steps to Reproduce: ==================== 1. create and mount distributed volume. (mount on multiple client) 2. [to reproduce race, we are putting breakpoint at dht_mkdir_hashed_dir_cbk and dht_rename_hashed_dir_cbk] 3. from one mount point execute [root@OVM1 race]# mkdir inprogress bricks:- [root@OVM5 race]# tree /brick*/race/ /brick1/race/ /brick2/race/ └── inprogress /brick3/race/ 1 directory, 0 files from another mount point:- [root@OVM1 race1]# mv inprogress rename bricks:- [root@OVM5 race]# tree /brick*/race/ /brick1/race/ └── rename /brick2/race/ └── inprogress /brick3/race/ └── inprogress 3 directories, 0 files 4. now continue bothe operation 5. verify data from another mount and bricks also mount:- [root@OVM5 race]# ls -lR .: total 0 drwxr-xr-x 2 root root 18 Jul 10 12:50 rename ./rename: total 0 [root@OVM5 race]# mkdir inprogress mkdir: cannot create directory `inprogress': File exists [root@OVM5 race]# ls -lR .: total 0 drwxr-xr-x 2 root root 18 Jul 10 12:50 inprogress drwxr-xr-x 2 root root 18 Jul 10 12:50 rename ./inprogress: total 0 ./rename: total 0 bricks:- same gfid:- [root@OVM5 race]# getfattr -d -m . /brick3/race/* -e hex getfattr: Removing leading '/' from absolute path names # file: brick3/race/inprogress trusted.gfid=0x5b3c1a8ca4b84f27912880710a165fb7 trusted.glusterfs.dht=0x000000010000000055555555aaaaaaa9 # file: brick3/race/rename trusted.gfid=0x5b3c1a8ca4b84f27912880710a165fb7 trusted.glusterfs.dht=0x000000010000000055555555aaaaaaa9 [root@OVM5 race]# tree /brick*/race/ /brick1/race/ ├── inprogress └── rename /brick2/race/ ├── inprogress └── rename /brick3/race/ ├── inprogress └── rename Actual results: =============== - same gfid for different Directories - sometimes files inside those directories are not listed on mount and Expected results: ================= - no two directory should have same gfid - all files inside those Directories should be accessible from mount point
Comment 2 Rachana Patel 2014-07-11 13:47:33 UTC
In case if destination directory exist, output would be rename1 already exist and race :- [root@OVM1 race]# mkdir rename [root@OVM1 race1]# mv rename rename1 output on mount:- [root@OVM5 race]# ls -lR .: total 0 drwxr-xr-x 2 root root 18 Jul 10 15:00 rename drwxr-xr-x 3 root root 57 Jul 10 15:00 rename1 ./rename: total 0 ./rename1: total 0 drwxr-xr-x 2 root root 18 Jul 10 15:00 rename ./rename1/rename: total 0 bricks:- [root@OVM5 race]# tree /brick*/race/ /brick1/race/ ├── rename └── rename1 └── rename /brick2/race/ ├── rename └── rename1 └── rename /brick3/race/ ├── rename └── rename1 └── rename 9 directories, 0 files [root@OVM5 race]# getfattr -d -m . -e hex /brick3/race/* -R getfattr: Removing leading '/' from absolute path names # file: brick3/race/rename trusted.gfid=0xac6b95cb620c400d91a55f3ce66ee005 trusted.glusterfs.dht=0x0000000100000000aaaaaaaaffffffff # file: brick3/race/rename1 trusted.gfid=0x9482dd3bf0834596bb74d6ffeffa40d2 trusted.glusterfs.dht=0x00000001000000000000000055555554 # file: brick3/race/rename1/rename trusted.gfid=0xac6b95cb620c400d91a55f3ce66ee005 trusted.glusterfs.dht=0x0000000100000000aaaaaaaaffffffff
Comment 7 Susant Kumar Palai 2015-12-28 06:25:45 UTC
Triage Update: RCA is known. Design and fix need to be done.
Comment 9 Raghavendra G 2016-04-11 05:25:59 UTC
Comment 12 Raghavendra G 2016-04-25 06:55:48 UTC
Sakshi, Is there a reason, you moved the bug back to MODIFIED? The patch is already merged. Can you please revisit and move the bug to modified if there is no valid reason? regards, Raghavendra
Comment 16 krishnaram Karthick 2016-05-16 09:06:10 UTC
The issue reported in the bug is still seen in build - glusterfs-3.7.9-4.el7rhgs.x86_64 With parallel mkdir and rename operation, mismatching gfids is seen on the directory under test. Moving this back to assigned.
Comment 22 Bhavana 2016-06-17 08:47:27 UTC
Thanks raghavendra, I have updated the doc text further, let me know if this looks ok.
Comment 23 Raghavendra G 2016-06-23 05:20:01 UTC
Doc text seems fine too.
Comment 24 Raghavendra G 2017-08-22 09:56:41 UTC
upstream patch https://review.gluster.org/15472 fixes this issue
Comment 28 Prasad Desala 2018-04-20 13:15:50 UTC
Comment 29 Srijita Mukherjee 2018-09-03 13:38:37 UTC
Updated the doc text. Kindly review and confirm
Comment 31 errata-xmlrpc 2018-09-04 06:26:56 UTC
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:2607