Bug 1118955

Summary:	Is lorax x86_64 -> x86-64 change really necessary?
Product:	[Fedora] Fedora	Reporter:	Bruce Jerrick <bmj001>
Component:	lorax	Assignee:	Brian Lane <bcl>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	21	CC:	anaconda-maint-list, bcl
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	lorax-21.17-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-09 20:46:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Bruce Jerrick 2014-07-12 08:38:47 UTC

Description of problem:
In lorax-21.15-1, spaces in media labels were replaced with hyphens
("Don't emit media labels with spaces in them").  But "x86_64" was
also changed to "x86-64" ('_' changed to hyphen).
That would seem to be an unnecessary proliferation of variations.
("x86_64" should be regarded as an atom, whereas '-' is used as a
syntactic separator.  And on the practical side, "x86_64" is the form
reported by, e.g., 'arch' and 'uname -i'.)

Version-Release number of selected component:
lorax-21.15-1.fc21

Instances of "x86-64" appear in:
    EFI/BOOT/grub.cfg
    isolinux/isolinux.cfg

Comment 1 Bruce Jerrick 2014-08-01 09:55:06 UTC

Thanks for the quick resolution.
I noticed in the pungi changelog, 3.05-1, the same "Don't emit media labels
with spaces in them" that started this.  Might pungi need the underscore fix
also?  (Sorry, but I'm not familiar with pungi, and I haven't looked into
it yet.)

Comment 2 Brian Lane 2014-08-01 20:36:26 UTC

No. The substitution was happening in the lorax template and it looks like pungi isn't doing any substitution, just creating the label w/o spaces. So everything should be fine at this point.