Bug 1118961

Summary: Failed to start thinkfan service
Product: [Fedora] Fedora Reporter: Germano Massullo <germano.massullo>
Component: thinkfanAssignee: Matt Spaulding <mspaulding06>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 20CC: germano.massullo, mspaulding06, sudhir
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1118993 (view as bug list) Environment:
Last Closed: 2014-07-12 21:41:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
thinkfan.conf
none
/etc/thinkfan.conf none

Description Germano Massullo 2014-07-12 10:34:01 UTC
Description of problem:
After the installation of the package, 
# systemctl start thinkfan
will fail.

# systemctl status thinkfan
gives:
thinkfan.service - simple and lightweight fan control program
   Loaded: loaded (/usr/lib/systemd/system/thinkfan.service; disabled)
   Active: failed (Result: resources) since sab 2014-07-12 12:28:32 CEST; 12s ago
  Process: 2322 ExecStart=/usr/sbin/thinkfan (code=exited, status=0/SUCCESS)

lug 12 12:28:32 localhost.localdomain systemd[1]: PID file /var/run/thinkfan.pid not readable (yet?) after start.
lug 12 12:28:32 localhost.localdomain systemd[1]: Failed to start simple and lightweight fan control program.
lug 12 12:28:32 localhost.localdomain systemd[1]: Unit thinkfan.service entered failed state.


Version-Release number of selected component (if applicable):
thinkfan-0.8.1-5.fc20.x86_64

Additional info:
my Thinkpad model: T60

Comment 1 Sudhir Khanger 2014-07-12 16:36:39 UTC
Why do you have thinkfan.service disabled?

What do you have in /etc/thinkfan.conf?

Can you please post output of following two commands?

find /sys/devices -type f -name "temp*_input"

and

sudo thinkfan -n

Comment 2 Sudhir Khanger 2014-07-12 16:47:02 UTC
I didn't notice that it was failing on my system to.

[donnie@fedora ~]$ systemctl status thinkfan
thinkfan.service - simple and lightweight fan control program
   Loaded: loaded (/usr/lib/systemd/system/thinkfan.service; enabled)
   Active: failed (Result: exit-code) since Sat 2014-07-12 14:48:10 IST; 7h ago
  Process: 1698 ExecStart=/usr/sbin/thinkfan (code=exited, status=4)

Jul 12 14:48:10 fedora thinkfan[1698]: thinkfan 0.8 starting...
Jul 12 14:48:10 fedora thinkfan[1698]: WARNING: Using default fan control in /proc/acpi/ibm/fan.
Jul 12 14:48:10 fedora thinkfan[1698]: /sys/devices/platform/coretemp.0/temp3_input: No such file or directory
Jul 12 14:48:10 fedora systemd[1]: thinkfan.service: control process exited, code=exited status=4
Jul 12 14:48:10 fedora systemd[1]: Failed to start simple and lightweight fan control program.
Jul 12 14:48:10 fedora systemd[1]: Unit thinkfan.service entered failed state.

[donnie@fedora ~]$ sudo thinkfan -n
[sudo] password for donnie: 

WARNING: Using default fan control in /proc/acpi/ibm/fan.
/sys/devices/platform/coretemp.0/temp3_input: No such file or directory
readconfig: Error getting temperature.
Refusing to run without usable config file!

It seems like location of sensor files have changed.

FROM

sensor /sys/devices/virtual/hwmon/hwmon0/temp1_input
sensor /sys/devices/platform/coretemp.0/temp3_input
sensor /sys/devices/platform/coretemp.0/temp1_input
sensor /sys/devices/platform/coretemp.0/temp2_input

TO

sensor /sys/devices/virtual/hwmon/hwmon0/temp1_input
sensor /sys/devices/platform/coretemp.0/hwmon/hwmon2/temp3_input
sensor /sys/devices/platform/coretemp.0/hwmon/hwmon2/temp1_input
sensor /sys/devices/platform/coretemp.0/hwmon/hwmon2/temp2_input

After replacing the above sensors, it has started working fine again.

[donnie@fedora ~]$ sudo thinkfan -n

WARNING: Using default fan control in /proc/acpi/ibm/fan.
WARNING: You're using simple temperature limits without correction values, and your fan will only start at 55 °C. This can be dangerous for your hard drive.

sleeptime=5, tmax=56, last_tmax=56, biased_tmax=56 -> fan="level 3"
sleeptime=2, tmax=61, last_tmax=57, biased_tmax=68 -> fan="level 7"
sleeptime=3, tmax=58, last_tmax=61, biased_tmax=62 -> fan="level 5"
sleeptime=5, tmax=58, last_tmax=58, biased_tmax=59 -> fan="level 4"
sleeptime=2, tmax=61, last_tmax=57, biased_tmax=68 -> fan="level 7"
sleeptime=3, tmax=59, last_tmax=61, biased_tmax=63 -> fan="level 5"
sleeptime=5, tmax=58, last_tmax=59, biased_tmax=59 -> fan="level 4"
^C
Caught deadly signal. Cleaning up and resetting fan control.
[donnie@fedora ~]$ sudo systemctl restart thinkfan.service
[donnie@fedora ~]$ systemctl status thinkfan
thinkfan.service - simple and lightweight fan control program
   Loaded: loaded (/usr/lib/systemd/system/thinkfan.service; enabled)
   Active: active (running) since Sat 2014-07-12 22:15:27 IST; 13s ago
  Process: 30113 ExecStart=/usr/sbin/thinkfan (code=exited, status=0/SUCCESS)
 Main PID: 30114 (thinkfan)
   CGroup: /system.slice/thinkfan.service
           └─30114 /usr/sbin/thinkfan

Jul 12 22:15:27 fedora systemd[1]: Starting simple and lightweight fan control program...
Jul 12 22:15:27 fedora thinkfan[30113]: thinkfan 0.8 starting...
Jul 12 22:15:27 fedora thinkfan[30113]: WARNING: Using default fan control in /proc/acpi/ibm/fan.
Jul 12 22:15:27 fedora thinkfan[30113]: WARNING: You're using simple temperature limits without correction values, and your fan will only start at 55 °C. ...ard drive.
Jul 12 22:15:27 fedora thinkfan[30113]: Daemon PID: 30114
Jul 12 22:15:27 fedora systemd[1]: Started simple and lightweight fan control program.
Hint: Some lines were ellipsized, use -l to show in full.

Comment 3 Germano Massullo 2014-07-12 16:48:16 UTC
Created attachment 917542 [details]
thinkfan.conf

(In reply to Sudhir Khanger from comment #1)
> Why do you have thinkfan.service disabled?

Because it is Fedora default policy for just installed services. I haven't yet enabled it, I just tried to start it, 


> What do you have in /etc/thinkfan.conf?

See attachment


># find /sys/devices -type f -name "temp*_input"

/sys/devices/virtual/hwmon/hwmon0/temp1_input
/sys/devices/virtual/hwmon/hwmon0/temp2_input
/sys/devices/platform/thinkpad_hwmon/temp12_input
/sys/devices/platform/thinkpad_hwmon/temp3_input
/sys/devices/platform/thinkpad_hwmon/temp13_input
/sys/devices/platform/thinkpad_hwmon/temp4_input
/sys/devices/platform/thinkpad_hwmon/temp14_input
/sys/devices/platform/thinkpad_hwmon/temp5_input
/sys/devices/platform/thinkpad_hwmon/temp15_input
/sys/devices/platform/thinkpad_hwmon/temp6_input
/sys/devices/platform/thinkpad_hwmon/temp16_input
/sys/devices/platform/thinkpad_hwmon/temp7_input
/sys/devices/platform/thinkpad_hwmon/temp10_input
/sys/devices/platform/thinkpad_hwmon/temp1_input
/sys/devices/platform/thinkpad_hwmon/temp8_input
/sys/devices/platform/thinkpad_hwmon/temp11_input
/sys/devices/platform/thinkpad_hwmon/temp2_input
/sys/devices/platform/thinkpad_hwmon/temp9_input
/sys/devices/platform/coretemp.0/hwmon/hwmon2/temp3_input
/sys/devices/platform/coretemp.0/hwmon/hwmon2/temp2_input


># thinkfan -n

WARNING: Using default fan control in /proc/acpi/ibm/fan.
WARNING: Using default temperature inputs in /proc/acpi/ibm/thermal.
WARNING: You're using simple temperature limits without correction values, and your fan will only start at 55 °C. This can be dangerous for your hard drive.
Module thinkpad_acpi doesn't seem to support fan_control

Comment 4 Sudhir Khanger 2014-07-12 17:17:04 UTC
Created attachment 917543 [details]
/etc/thinkfan.conf

Comment 5 Sudhir Khanger 2014-07-12 17:21:49 UTC
> Because it is Fedora default policy for just installed services. I haven't yet enabled it, I just tried to start it,

It is not started because you have to manually set it up to work. It's failing because you haven't set it up properly.

> Module thinkpad_acpi doesn't seem to support fan_control

Let's make sure you have modules for thinkfan to work.

You should have a file /etc/modprobe.d/thinkfan.conf

cat /etc/modprobe.d/thinkfan.conf
options thinkpad_acpi fan_control=1

It will be safe to restart your system to load thinkpad_acpi

See my attachment to how to setup /etc/thinkfan.conf or this wiki entry https://wiki.archlinux.org/index.php/Lenovo_ThinkPad_T420#Fans

Basically stick sensor in front of the sensors list you generated in the last post and append it above the temperature list in /etc/thinkfan.conf

Comment 6 Germano Massullo 2014-07-12 21:41:49 UTC
Ok now it works.
I think that Thinkfan should compile on its own the thinkfan.conf file by auto retrieving infos of
>find /sys/devices -type f -name "temp*_input"

I have opened a new bugreport for that https://bugzilla.redhat.com/show_bug.cgi?id=1118993