Bug 1119158
| Summary: | Review Request: perl-URL-Encode - Encoding and decoding of application/x-www-form-urlencoded encoding | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, package-review, psabata |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-02 15:40:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1181321 | ||
| Bug Blocks: | 201449, 1119118 | ||
|
Description
Christopher Meng
2014-07-14 07:33:58 UTC
TODO: Raise the minimum EE::MM version requirement to 6.76 TODO: Remove the extra Carp runtime dependency. This is always autodetected. FIX: Missing a builddep for t/* - utf8 FIX: Missing lots of builddeps for the bundled Module::Install -- base, Config, Cwd, ExtUtils::MM_Unix, Fcntl, File::Find, File::Path, Pod::Text, vars (In reply to Petr Šabata from comment #1) > FIX: Missing lots of builddeps for the bundled Module::Install -- base, > Config, Cwd, ExtUtils::MM_Unix, Fcntl, File::Find, File::Path, Pod::Text, > vars Question, will this be absorbed by guideline? IMO these are not important or should the building environment auto detect these? Since Module::Install is often bundled. (In reply to Christopher Meng from comment #2) > (In reply to Petr Šabata from comment #1) > > FIX: Missing lots of builddeps for the bundled Module::Install -- base, > > Config, Cwd, ExtUtils::MM_Unix, Fcntl, File::Find, File::Path, Pod::Text, > > vars > > Question, will this be absorbed by guideline? IMO these are not important or > should the building environment auto detect these? Since Module::Install is > often bundled. The reason for listing those is exactly the same as listing any other. The module is used at build time and it has these dependencies. Bundled modules (if used for build only) are no special case. If you don't feel like going through the inc/ directory, one way to deal with this is removing it, dropping it from MANIFEST and BR'ing inc::Module::Install. However, given this may change how your package gets built, you may want to stick with just checking inc for dependencies, too. It's not that much work, really. Ping. Any updates, Christopher? Another ping. Are you still interested in packaging this? Dead review. Closing. |