Bug 1120202

Summary:	Review Request: perl-ExtUtils-MakeMaker-CPANfile - CPANfile support for ExtUtils::MakeMaker
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	David Dick <ddick>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ddick, package-review
Target Milestone:	---	Flags:	ddick: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-ExtUtils-MakeMaker-CPANfile-0.06-1.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-07-17 13:32:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1120153

Description Petr Pisar 2014-07-16 12:07:59 UTC

Spec URL: http://ppisar.fedorapeople.org/perl-ExtUtils-MakeMaker-CPANfile/perl-ExtUtils-MakeMaker-CPANfile.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-ExtUtils-MakeMaker-CPANfile/perl-ExtUtils-MakeMaker-CPANfile-0.06-1.fc22.src.rpm
Description:
ExtUtils::MakeMaker::CPANfile loads cpanfile in your distribution and
modifies parameters for WriteMakefile in your Makefile.PL. Just use it
instead of ExtUtils::MakeMaker (which should be loaded internally), and
prepare cpanfile.

Fedora Account System Username: ppisar

Comment 1 David Dick 2014-07-17 11:30:40 UTC

License is correct.

Build and Run Time Requires are correct.

README.md could be added to %doc

Due to Module::CPANfile only being available in f21+, you could use NO_PACKLIST=1 to eliminate the packlist removal.

Package builds at http://koji.fedoraproject.org/koji/taskinfo?taskID=7156974

rpmlint is clean

No blockers.

Package APPROVED.

Comment 2 David Dick 2014-07-17 11:34:19 UTC

One last thing, perl(version) >= 0.76 could be added to Run Time Requires, which would require an update to the %global __requires_exclude section.

Comment 3 Petr Pisar 2014-07-17 11:44:12 UTC

New Package SCM Request
=======================
Package Name: perl-ExtUtils-MakeMaker-CPANfile
Short Description: CPANfile support for ExtUtils::MakeMaker
Upstream URL: http://search.cpan.org/dist/ExtUtils-MakeMaker-CPANfile/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2014-07-17 12:12:24 UTC

Git done (by process-git-requests).

Comment 5 Petr Pisar 2014-07-17 13:32:26 UTC

Thank you for the review and the repository. I added the README.md and the exact version version.