Bug 1120299
Summary: | Review Request: perl-Inline-Struct - Manipulate C structures directly from Perl | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, ppisar, tcallawa |
Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-Inline-Struct-0.06-1.fc21 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-08-12 08:49:47 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1120293 | ||
Bug Blocks: |
Description
Petr Šabata
2014-07-16 16:37:41 UTC
URL and Source0 are usable. Ok. Archive tar ball is original (SHA-256: c882ed94eb8011861ae70c566a0a37b857342b95233db99fa162aa2c3de26d67). Ok. FATAL: The license statements contradict: README states "All Rights Reserved" while Struct.pod states "as Perl" but points to (Artistic) only. Please clarify it with upstream and/or Fedora legal departement. All Rights Reserved is a legal no-op. It means nothing, just ignore it. Despite being a bit confusing, this is clearly meant to be under the same terms as Perl itself, which is "Artistic or GPL+" and is fine for Fedora. Lifting FE-Legal. Thanks for clarification. I reported the link botch as <https://rt.cpan.org/Public/Bug/Display.html?id=97756> to the upstream. License verified from Struct.pod. Ok. Summary verified from Struct.pod. Ok. Description verified from Struct.pod. Ok. No XS code, noarch BuildArch is Ok. FIX: `perl(Parse::RecDEscent)' build-dependency is not provided by any package. Thanks. Typo fixed and links updated. Spec file changes: --- perl-Inline-Struct.spec.old 2014-07-17 16:25:42.000000000 +0200 +++ perl-Inline-Struct.spec 2014-08-05 14:23:55.000000000 +0200 @@ -13,7 +13,7 @@ BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 BuildRequires: perl(Inline) BuildRequires: perl(Inline::C) -BuildRequires: perl(Parse::RecDEscent) +BuildRequires: perl(Parse::RecDescent) BuildRequires: perl(strict) BuildRequires: perl(vars) Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) > FIX: `perl(Parse::RecDEscent)' build-dependency is not provided by any package. -BuildRequires: perl(Parse::RecDEscent) +BuildRequires: perl(Parse::RecDescent) Ok. All build-time dependencies are declared. Ok. All tests pass. Ok. $ rpmlint perl-Inline-Struct.spec ../SRPMS/perl-Inline-Struct-0.06-1.fc22.src.rpm ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm perl-Inline-Struct.src: W: spelling-error %description -l en_US typemaps -> type maps, type-maps, typecast perl-Inline-Struct.noarch: W: spelling-error %description -l en_US typemaps -> type maps, type-maps, typecast 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Aug 5 14:32 /usr/share/doc/perl-Inline-Struct -rw-r--r-- 1 root root 1808 Jun 11 2001 /usr/share/doc/perl-Inline-Struct/README -rw-r--r-- 1 root root 619 May 2 2001 /usr/share/doc/perl-Inline-Struct/TODO -rw-r--r-- 1 root root 4017 Aug 5 14:32 /usr/share/man/man3/Inline::Struct.3pm.gz drwxr-xr-x 2 root root 0 Aug 5 14:32 /usr/share/perl5/vendor_perl/Inline drwxr-xr-x 2 root root 0 Aug 5 14:32 /usr/share/perl5/vendor_perl/Inline/Struct -rw-r--r-- 1 root root 10099 Jun 11 2001 /usr/share/perl5/vendor_perl/Inline/Struct.pm -rw-r--r-- 1 root root 5227 May 14 2001 /usr/share/perl5/vendor_perl/Inline/Struct.pod -rw-r--r-- 1 root root 4686 Jun 11 2001 /usr/share/perl5/vendor_perl/Inline/Struct/grammar.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Carp) 1 perl(Data::Dumper) 1 perl(Inline) 1 perl(Inline::Struct::grammar) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `perl(Parse::RecDescent)' (Struct.pm:20). $ rpm -q --provides -p ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Inline::Struct) = 0.06 1 perl(Inline::Struct::grammar) = 0.10 1 perl-Inline-Struct = 0.06-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7243399). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all the `FIX' items, and provides new spec file. Resolution: NOT approved. Links updated. Spec file changes: --- perl-Inline-Struct.spec.old 2014-08-05 14:23:55.000000000 +0200 +++ perl-Inline-Struct.spec 2014-08-05 16:10:54.000000000 +0200 @@ -17,6 +17,7 @@ BuildRequires: perl(strict) BuildRequires: perl(vars) Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) +Requires: perl(Parse::RecDescent) %description Inline::Struct is not a new language. It's a language extension designed to All tests pass. Ok. $ rpmlint perl-Inline-Struct.spec ../SRPMS/perl-Inline-Struct-0.06-1.fc22.src.rpm ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm perl-Inline-Struct.src: W: spelling-error %description -l en_US typemaps -> type maps, type-maps, typecast perl-Inline-Struct.noarch: W: spelling-error %description -l en_US typemaps -> type maps, type-maps, typecast 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. > FIX: Run-require `perl(Parse::RecDescent)' (Struct.pm:20). $ rpm -q --requires -p ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Carp) 1 perl(Data::Dumper) 1 perl(Inline) 1 perl(Inline::Struct::grammar) 1 perl(Parse::RecDescent) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Inline-Struct-0.06-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7246655). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. New Package SCM Request ======================= Package Name: perl-Inline-Struct Short Description: Manipulate C structures directly from Perl Upstream URL: http://search.cpan.org/dist/Inline-Struct/ Owners: psabata jplesnik ppisar Branches: f21 InitialCC: perl-sig Git done (by process-git-requests). Thank you both. Package Change Request ====================== Package Name: perl-Inline-Struct Branches: f21 master Owners: InitialCC: perl-sig The package database is missing the InialCC records again. Please add them and fix your tool. Complete. |