Bug 1120473
Summary: | setxid wrapper in glibc-2.19.90-29 is miscompiled due to gcc bug | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Valdis Kletnieks <valdis.kletnieks> |
Component: | glibc | Assignee: | Carlos O'Donell <codonell> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | a9016009, awilliam, bruno, codonell, fweimer, i, jakub, jan.kratochvil, law, pfrankli, pomidorabelisima, robatino, spoyarek |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-07-30 08:11:36 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Valdis Kletnieks
2014-07-17 03:36:35 UTC
Looking at the glibc bugzilla and ChangeLog, I suspect it's possibly related to Florian Weimer's work on bugs 17135 and/or 13347, or possibly this: 2014-07-07 Roland McGrath <roland.com> * sysdeps/nptl/lowlevellock.h: File removed. * NEWS: NPTL is no longer an add-on! Not sure which though.... I have been having a problem with this as well. Downgrading to the previous version of glibc in rawhide made things work again. For me h, sshd, scp, and crond. Fortunately I was still able to run yum downgrade in a pre-existing root shell to fix things. Bad news here. One machine installed this update and forgot to downgrade now reboot and no longer can use the system anymore. per c#3, this sounds bad enough to be an Alpha blocker, https://fedoraproject.org/wiki/Fedora_21_Alpha_Release_Criteria#Expected_installed_system_boot_behavior . This hasn't appeared in branched yet, so it's a bit premature for it to be a blocker. (Currently it's only affecting rawhide.) whoops, you're quite right, my bad. withdrawing. if you could keep an eye and re-propose if it hits f21, though, that'd be great. I'm keeping an eye on it. My primary desktop at home is using rawhide and I'll need to watch updates until it's fixed. (I could lock the glibc version, but that makes it harder to watch for updates.) I think if this is going to be a while before it is fixed, that the maintainer should untag the bad version from rawhide. And the more I think about it, the more I wonder why 64-bit code works, but 32-bit code blows chunks in a spectacular manner. (And for that matter, why does strace report 'setuid()' in 64 bit mode, but 'setuid32()' in 32-bit mode?) systemd-logind.service entered failed state - has no holdoff time - i686 https://bugzilla.redhat.com/show_bug.cgi?id=1121419 (In reply to Valdis Kletnieks from comment #1) > Looking at the glibc bugzilla and ChangeLog, I suspect it's possibly related > to Florian Weimer's work on bugs 17135 and/or 13347, or possibly this: > > > 2014-07-07 Roland McGrath <roland.com> > * sysdeps/nptl/lowlevellock.h: File removed. > * NEWS: NPTL is no longer an add-on! > > Not sure which though.... https://bugzilla.redhat.com/show_bug.cgi?id=1121419#c6 Maintainers: as this is completely breaking 32-bit Rawhide machines, if you don't have a fix coming pretty soon, could you please revert the changes from -29 until they can be fixed? Thanks. *** Bug 1121419 has been marked as a duplicate of this bug. *** Please feel free to untag; Carlos and I are travelling and it is likely that we may not be able to get to it soon enough. It turns out this is was a GCC bug, reported here (for the very same glibc code): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61801 It has already been fixed in gcc-4.9.1-2 in rawhide, so simply recompiling glibc should fix this bug. I have built -30 with the resync reverted for now. I'll do another resync next week and check if this bug is fixed on i686. (In reply to Florian Weimer from comment #14) > It turns out this is was a GCC bug, reported here (for the very same glibc > code): https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61801 > > It has already been fixed in gcc-4.9.1-2 in rawhide, so simply recompiling > glibc should fix this bug. Hey Florian, thanks for finding the *real* cause - I'd never have found that. I got distracted by the fact it was in NPTL code and I couldn't figure out why a single-threaded program was doing that. -30 does alleviate the immediate issue. I don't know whether you'd like to keep this open until things are fully fixed or just close this now since the fixed build is in rawhide (though it didn't make this morning's compose). (In reply to Bruno Wolff III from comment #17) > -30 does alleviate the immediate issue. I don't know whether you'd like to > keep this open until things are fully fixed or just close this now since the > fixed build is in rawhide (though it didn't make this morning's compose). I'll close it once I do the next rebase and confirm that the problem is fixed. Tested latest master on i686 and x86_64 and I don't see any disasters like bricked boxes/vms and basic functionality like rebooting, restarting services and internet connectivity (including yum check-update with a clean cache) works, so I've pushed a rawhide rebase: http://koji.fedoraproject.org/koji/taskinfo?taskID=7204483 I'll close the bug once the build completes. |