Bug 1120563 (ocramius/instantiator)

Summary: Review Request: php-ocramius-instantiator - Instantiate objects in PHP without invoking their constructors
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: php-ocramius-instantiator-1.0.0-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-30 06:55:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1120543    
Bug Blocks:    
Attachments:
Description Flags
fedora-review.txt
none
phpcompatinfo.log none

Description Remi Collet 2014-07-17 07:21:51 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/569276dfb2a8905e141dd58a00f86346e7b4a4cc/php/php-ocramius-instantiator/php-ocramius-instantiator.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-ocramius-instantiator-1.0.0-1.remi.src.rpm
Description: 
This library provides a way of avoiding usage of constructors when
instantiating PHP classes.

Fedora Account System Username: remi

Comment 1 Remi Collet 2014-07-17 07:22:26 UTC
As usually, I will clean EL-5 stuff after import.

This is a new dependency of PHPUnit.

Comment 2 Shawn Iwinski 2014-07-21 00:33:44 UTC
Created attachment 919487 [details]
fedora-review.txt

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1120563
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 3 Shawn Iwinski 2014-07-21 00:34:12 UTC
Created attachment 919488 [details]
phpcompatinfo.log

phpcompatinfo version 2.26.0

Comment 4 Shawn Iwinski 2014-07-21 00:35:49 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove after initial import.



[x]: Requires correct, justified where necessary.
     
     From phpcompatinfo:
         Requires: php-spl

Non-blocker because provided by php core.  Can be added after initial import.



No blockers.

===== APPROVED =====

Comment 5 Remi Collet 2014-07-21 04:35:10 UTC
Thanks again for the review.

New Package SCM Request
=======================
Package Name: php-ocramius-instantiator
Short Description: Instantiate objects in PHP without invoking their constructors
Upstream URL: https://github.com/Ocramius/Instantiator
Owners: remi
Branches: f19 f20 f21 el6 epel7
InitialCC:

Comment 6 Gwyn Ciesla 2014-07-21 12:54:29 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2014-07-21 14:58:15 UTC
php-ocramius-instantiator-1.0.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/php-ocramius-instantiator-1.0.0-1.fc19

Comment 8 Fedora Update System 2014-07-21 14:58:39 UTC
php-ocramius-instantiator-1.0.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-ocramius-instantiator-1.0.0-1.fc20

Comment 9 Fedora Update System 2014-07-21 14:58:52 UTC
php-ocramius-instantiator-1.0.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-ocramius-instantiator-1.0.0-1.el6

Comment 10 Fedora Update System 2014-07-22 03:32:46 UTC
php-ocramius-instantiator-1.0.0-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 11 Fedora Update System 2014-07-30 06:55:59 UTC
php-ocramius-instantiator-1.0.0-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 12 Fedora Update System 2014-07-30 06:56:28 UTC
php-ocramius-instantiator-1.0.0-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 13 Fedora Update System 2014-08-07 11:49:59 UTC
php-ocramius-instantiator-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.