Bug 1120611
Summary: | help urls launched from application help buttons and other url handlers don't work after glib2 rebase | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | xingge <gxing> |
Component: | glib2 | Assignee: | Ray Strode [halfline] <rstrode> |
Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
Severity: | urgent | Docs Contact: | |
Priority: | high | ||
Version: | 6.6 | CC: | bkearney, bnocera, fsharath, jkoten, ldai, liliu, mbarta, msimon, qianzhan, rstrode, salmy, tpelka, walters |
Target Milestone: | rc | Keywords: | Rebase, Regression |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | glib2-2.28.8-2.el6 | Doc Type: | Bug Fix |
Doc Text: |
This is a bug fix in an unreleased rebase, and so we don't need to document the bug (which has never reached customers)
Cause:
Consequence:
Fix:
Result:
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2014-10-14 07:28:59 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1014343 |
Description
xingge
2014-07-17 09:29:40 UTC
So this seems to be a regression in glib2 from when it got rebased from 2.26 to 2.28. During the 2.28 development cycle, the way URL handlers were processed was changed. See: https://bugzilla.gnome.org/show_bug.cgi?id=631410 That change means url schemes registered via gconf (via the gvfs module) no longer get consulted. yelp registers the ghelp: uri scheme using gconf. We can "fix" it by making yelp use the new scheme: - updating /usr/share/applications/gnome-yelp.desktop to have x-scheme-handler/ghelp on the MimeTypes line (and running update-desktop-database /usr/share/applications) but there's probably more widespread breakage. Instead, I think the most conservative move would be to revert the change by shipping a reversed patch of https://git.gnome.org/browse/glib/commit/?id=9b262f1c5fe5a6fd879f17cd7b80d8c54e33d80c in the spec file. Bastien, Colin, do you guys agree that's the right course of action? well a straight up reversal of the patch won't work, since it was partially reverted a few commits after it was introduced: https://git.gnome.org/browse/glib/commit/?id=fb94859e84c0b7859a0a5425d461b18e67ea9ac7 But, assuming Bastien/Colin agree, I think reverting the part that hasn't yet been reverted makes sense. It's the right course of action if you want to keep the exact same API between RHEL6 releases. Reverting https://git.gnome.org/browse/glib/commit/?id=fb94859e84c0b7859a0a5425d461b18e67ea9ac7 won't be enough though. You'll need to make sure that the glib code to read the scheme handler from mime-types is also removed so that the extension point is always used. Colin said he's on board with this plan, too, so clearing needinfos. It's messier than that though - the higher up we rebase, the more we need to do *both* - if say Evolution is installing desktop file mime types, we need to support that too. ugh, so i guess the answer for that is if g_desktop_app_info_lookup_get_default_for_uri_scheme() returns NULL then fall back to the new way. Thankfully the new way is only 5 lines of code. *** Bug 1126901 has been marked as a duplicate of this bug. *** *** Bug 1115903 has been marked as a duplicate of this bug. *** I don't know this area of the code very well; Bastien, would you have time to look at this? *** Bug 1142427 has been marked as a duplicate of this bug. *** Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2014-1538.html |