Bug 1120857
| Summary: | Review Request: golang-github-mreiferson-go-httpclient - A Go HTTP client library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Colin Walters <walters> | ||||
| Component: | Package Review | Assignee: | Lokesh Mandvekar <lsm5> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | eparis, jchaloup, lsm5, package-review, vbatts | ||||
| Target Milestone: | --- | Flags: | lsm5:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-09-22 08:06:19 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1047194 | ||||||
| Attachments: |
|
||||||
|
Description
Colin Walters
2014-07-17 21:27:48 UTC
Jan, Is this the latest git location of the spec file Eric, yes, it is. $ rpmlint golang-github-mreiferson-go-httpclient.spec golang-github-mreiferson-go-httpclient.spec:30: W: setup-not-quiet Vincent, I guess * preserve timestamps of source copied is still valid here. Otherwise, the tarball contains only: $ ls httpclient.go httpclient_test.go LICENSE README.md Created attachment 936275 [details]
tweaks on layout
comments to accommodate the attached patch:
* %{gopath} is provided by the golang rpm
* exclusivearch to have this not build on the ppc and s390 builders
* sane version constaints
* this -devel is noarch
* preserve time on source
* include tests
* removing the directories that are owned by the golang rpm
* include the version in the changelog
$ rpmlint golang-github-mreiferson-go-httpclient.spec golang-github-mreiferson-go-httpclient.spec:30: W: setup-not-quiet 0 packages and 1 specfiles checked; 0 errors, 1 warnings. Patch + rpmlint warnings applied. Pull request created. Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-mreiferson-go-httpclient/golang-github-mreiferson-go-httpclient.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-mreiferson-go-httpclient/golang-github-mreiferson-go-httpclient-0-0.0.gitc121dfe.fc21.src.rpm Description: A Go HTTP client library $ rpmlint /root/rpmbuild/SRPMS/golang-github-mreiferson-go-httpclient-0-0.0.gitc121dfe.fc21.src.rpm /root/rpmbuild/RPMS/noarch/golang-github-mreiferson-go-httpclient-devel-0-0.0.gitc121dfe.fc21.noarch.rpm golang-github-mreiferson-go-httpclient.spec golang-github-mreiferson-go-httpclient.src: W: spelling-error %description -l en_US librarys -> library, library's, library s golang-github-mreiferson-go-httpclient.src:38: W: macro-in-comment %check golang-github-mreiferson-go-httpclient.src:39: W: macro-in-comment %{buildroot} golang-github-mreiferson-go-httpclient.src:39: W: macro-in-comment %{gopath} golang-github-mreiferson-go-httpclient.src:39: W: macro-in-comment %{gopath} golang-github-mreiferson-go-httpclient.src:39: W: macro-in-comment %{import_path} golang-github-mreiferson-go-httpclient.spec:38: W: macro-in-comment %check golang-github-mreiferson-go-httpclient.spec:39: W: macro-in-comment %{buildroot} golang-github-mreiferson-go-httpclient.spec:39: W: macro-in-comment %{gopath} golang-github-mreiferson-go-httpclient.spec:39: W: macro-in-comment %{gopath} golang-github-mreiferson-go-httpclient.spec:39: W: macro-in-comment %{import_path} 2 packages and 1 specfiles checked; 0 errors, 11 warnings. Initial commit by Colin Walters Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7592220 %check commented so we can enable the test in future, now it fails to check in koji. %check is likely gonna fail in koji: + go test github.com/mreiferson/go-httpclient --- FAIL: TestHttpsConnection (1.00 seconds) httpclient_test.go:93: 1st request failed - Get https://httpbin.org/ip: dial tcp: i/o timeout FAIL FAIL github.com/mreiferson/go-httpclient 3.963s error: Bad exit status from /var/tmp/rpm-tmp.OK8Fqh (%check) Hey Vincent, I'm kinda bored and finishing up the review for this :). It's pretty much done anyway. Vincent, btw, I don't think we need "ExclusiveArch: %{go_arches} noarch" in the main package. We could just have BuildArch: noarch in the devel package for now.
Also, aren't %{go_arches} and noarch contradictory?
Changes applied Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-mreiferson-go-httpclient/golang-github-mreiferson-go-httpclient.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-mreiferson-go-httpclient/golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc21.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7631916 LGTM. specfile follows golang packaging draft guidelines: https://fedoraproject.org/wiki/PackagingDrafts/Go New Package SCM Request ======================= Package Name: golang-github-mreiferson-go-httpclient Short Description: A Go HTTP client library Upstream URL: https://github.com/mreiferson/go-httpclient/ Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc20 golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc21 golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc21 has been pushed to the Fedora 21 stable repository. golang-github-mreiferson-go-httpclient-0-0.1.gitc121dfe.fc20 has been pushed to the Fedora 20 stable repository. |