Bug 1120865
| Summary: | Review Request: golang-github-BurntSushi-toml | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Colin Walters <walters> | ||||
| Component: | Package Review | Assignee: | Vincent Batts <vbatts> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | eparis, jchaloup, package-review, vbatts, walters | ||||
| Target Milestone: | --- | Flags: | vbatts:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | golang-github-BurntSushi-toml-0-0.3.git2ceedfe.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-09-22 10:00:50 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1047194 | ||||||
| Attachments: |
|
||||||
|
Description
Colin Walters
2014-07-17 21:38:26 UTC
Created attachment 921044 [details]
spec tweaks
Comments to accommodate this patch:
* %{gopath} is in the rpm macros, and set exclusive arch too, to prevent s390 builds
* move the buildarch noarch to the devel, since it is source only
* preserve timestamps of source copied
* and as an added perk, the tomlv command provided in this project is useful for validating *.toml files, so we could build and include it in the main rpm.
After applying the patch $ rpmlint golang-github-BurntSushi-toml.spec golang-github-BurntSushi-toml.spec:14: W: unversioned-explicit-provides tomlv golang-github-BurntSushi-toml.spec:30: W: setup-not-quiet 0 packages and 1 specfiles checked; 0 errors, 2 warnings. Jan, did you update github? Or send a pull request? Pull request created. Colin, can you give me commit rights? one other nit, that I've just thought of.
```
Release: 0.git%{shortcommit}%{?dist}
```
out to be:
```
Release: 0.0.git%{shortcommit}%{?dist}
```
reason being that the version will not be incremented just because the git bundle is updated. So we'll use the first position for updates to the git bundle. The second position is for normal release type incrementing.
ah, also in %check:
-GOPATH=%{gopath}:%{buildroot}/%{gopath} go test %{import_path}
+GOPATH=%{buildroot}/%{gopath}:%{gopath} go test %{import_path}
Because the test will step through GOPATH, first to last looking for the %{import_path} that is being tested.
Pushed. New Package SCM Request ======================= Package Name: golang-github-BurntSushi-toml Short Description: TOML parser and encoder for Go with reflection Upstream URL: https://github.com/BurntSushi/toml Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). golang-github-BurntSushi-toml-0-0.2.gitbd2bdf7.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-BurntSushi-toml-0-0.2.gitbd2bdf7.fc20 golang-github-BurntSushi-toml-0-0.2.gitbd2bdf7.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-BurntSushi-toml-0-0.2.gitbd2bdf7.fc21 golang-github-BurntSushi-toml-0-0.2.gitbd2bdf7.fc21 has been pushed to the Fedora 21 stable repository. golang-github-BurntSushi-toml-0-0.2.gitbd2bdf7.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-BurntSushi-toml-0-0.2.gitbd2bdf7.el6 golang-github-BurntSushi-toml-0-0.2.gitbd2bdf7.fc20 has been pushed to the Fedora 20 stable repository. golang-github-BurntSushi-toml-0-0.3.git2ceedfe.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-BurntSushi-toml-0-0.3.git2ceedfe.el6 golang-github-BurntSushi-toml-0-0.3.git2ceedfe.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-BurntSushi-toml-0-0.3.git2ceedfe.fc20 golang-github-BurntSushi-toml-0-0.3.git2ceedfe.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-BurntSushi-toml-0-0.3.git2ceedfe.fc21 golang-github-BurntSushi-toml-0-0.3.git2ceedfe.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-github-BurntSushi-toml-0-0.3.git2ceedfe.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |