Bug 1120867
| Summary: | Review Request: golang-github-rcrowley-go-metrics - Go port of Coda Hales Metrics library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Colin Walters <walters> | ||||
| Component: | Package Review | Assignee: | Lokesh Mandvekar <lsm5> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | jchaloup, lsm5, package-review, vbatts | ||||
| Target Milestone: | --- | Flags: | lsm5:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.el6 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-09-22 07:23:46 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1047194 | ||||||
| Attachments: |
|
||||||
|
Description
Colin Walters
2014-07-17 21:42:02 UTC
Created attachment 936279 [details]
tweaks on layout
comments to accommodate the attached patch:
* %{gopath} is provided by the golang rpm
* exclusivearch to have this not build on the ppc and s390 builders
* sane version constaints
* this -devel is noarch
* preserve time on source
* include tests
* removing the directories that are owned by the golang rpm
* include the version in the changelog
Applied, pull request created. Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rcrowley-go-metrics/golang-github-rcrowley-go-metrics.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rcrowley-go-metrics/golang-github-rcrowley-go-metrics-0-0.0.git3be59ce.fc21.src.rpm Description: Go port of Coda Hales Metrics library $ rpmlint /root/rpmbuild/SRPMS/golang-github-rcrowley-go-metrics-0-0.0.git3be59ce.fc21.src.rpm /root/rpmbuild/RPMS/noarch/golang-github-rcrowley-go-metrics-devel-0-0.0.git3be59ce.fc21.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Initial commit by Colin Walters Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7591805 BuildArch: noarch for main package defattr and attrs aren't needed in files listing (doesn't hurt either way) everything else LGTM also ..feel free to replace repo and project values with macros defined on top, no big deal :) Changes applied Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rcrowley-go-metrics/golang-github-rcrowley-go-metrics.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rcrowley-go-metrics/golang-github-rcrowley-go-metrics-0-0.1.git3be59ce.fc21.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7633834 LGTM. specfile follows golang packaging draft guidelines: https://fedoraproject.org/wiki/PackagingDrafts/Go New Package SCM Request ======================= Package Name: golang-github-rcrowley-go-metrics Short Description: Go port of Coda Hales Metrics library Upstream URL: https://github.com/rcrowley/go-metrics/ Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig Git done (by process-git-requests). golang-github-rcrowley-go-metrics-0-0.1.git3be59ce.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-rcrowley-go-metrics-0-0.1.git3be59ce.fc20 golang-github-rcrowley-go-metrics-0-0.1.git3be59ce.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-rcrowley-go-metrics-0-0.1.git3be59ce.fc21 golang-github-rcrowley-go-metrics-0-0.1.git3be59ce.fc21 has been pushed to the Fedora 21 stable repository. golang-github-rcrowley-go-metrics-0-0.1.git3be59ce.fc20 has been pushed to the Fedora 20 stable repository. golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.fc20 golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.fc21 golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.el6 golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-github-rcrowley-go-metrics-0-0.2.gitdee209f.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |