Bug 1121237

Summary: CommandExecutor should handle exception in CallBackMethods
Product: [Retired] oVirt Reporter: Ravi Nori <rnori>
Component: ovirt-engine-coreAssignee: Ravi Nori <rnori>
Status: CLOSED CURRENTRELEASE QA Contact: Ravi Nori <rnori>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.5CC: amureini, ecohen, gklein, iheim, oourfali, rbalakri, rnori, yeylon
Target Milestone: ---Keywords: CodeChange
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: ovirt-3.5.0_rc1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-17 12:41:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ravi Nori 2014-07-18 17:37:10 UTC 
Description of problem: If one of the callback methods raises an exception, the framework keeps calling the method again the next loop iteration.  In some circumstances this means the command will never converge--e.g. coding errors, database connection failures, etc. 


Version-Release number of selected component (if applicable): 3.5


Expected results: the framework to abort execution of that command altogether
Comment 1 Petr Beňas 2014-09-10 17:46:13 UTC 
Please provide steps to reproduce.
Comment 2 Ravi Nori 2014-09-10 18:39:04 UTC 
This is internal code change
Comment 3 Sandro Bonazzola 2014-10-17 12:41:55 UTC 
oVirt 3.5 has been released and should include the fix for this issue.