Bug 1121988
Summary: | Review Request: zanata-python-client - Python Client for Zanata Server | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | anish <apatil> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | gwync, i18n-bugs, package-review, panemade, petersen |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | zanata-python-client-1.3.14-3.fc20 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-08-08 08:41:07 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
anish
2014-07-22 09:50:20 UTC
Review: + mock build is successful for f22. + rpmlint output on rpms gave zanata-python-client.noarch: E: explicit-lib-dependency python-hashlib zanata-python-client.noarch: E: incorrect-fsf-address /usr/bin/flies zanata-python-client.noarch: W: no-manual-page-for-binary flies zanata-python-client.noarch: W: no-manual-page-for-binary zanata zanata-python-client.src:179: W: macro-in-%changelog %doc 2 packages and 0 specfiles checked; 2 errors, 3 warnings. + Source verified with upstream as (sha256sum) srpm tarball :9cbc8cacc3f86327e2a2aa902cd8215df3964dc23b395043338d75460aebd77b upstream tarball :9cbc8cacc3f86327e2a2aa902cd8215df3964dc23b395043338d75460aebd77b + License "MIT" is valid and is included in its own file as %doc + rest looks following packaging guidelines. Suggestions: 1) Ask upstream to fix the fsf address in /usr/bin/flies 2) every '%' character in changelog should be written as '%%' 3) you don't need sitelib macro for current Fedora releases %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} drop above. 4) Drop Group tag 5) Instead of following %if 0%{?fedora} < 13 BuildRequires: python-devel %endif just add BuildRequires: python2-devel we want this BR: for python packages 6) Change %{__python} to %{__python2} 7) drop %clean 8) change %{python_sitelib} to %{python2_sitelib} 9) drop defattr line Check more on http://fedoraproject.org/wiki/Packaging:Python ugh! pasting mistake. I see license for this package is LGPLv2+ Drop COPYING file in %doc as it contains GPLv3+ text which is not related to this package. Good to drop it from upstream also. Hi Parag Thank you for your review comments, I have opened a bug for correct fsf file on upstream Please find new SRPM and Spec file on Spec URL: http://anishpatil.fedorapeople.org/zanata-python-client.spec SRPM URL: http://anishpatil.fedorapeople.org/zanata-python-client-1.3.14-2.fc20.src.rpm Few more fixes needed 1) In above link spec I can still see COPYING packaged, remove it 2) change %{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT to %{__python2} setup.py install --skip-build --root $RPM_BUILD_ROOT 3)change python2 setup.py build to %{__python2} setup.py build All this is given on http://fedoraproject.org/wiki/Packaging:Python#Example_spec_file Hi Parag! Thank you for your review comments Please find new spec and SRPM file on Spec URL: http://anishpatil.fedorapeople.org/zanata-python-client.spec SRPM URL: http://anishpatil.fedorapeople.org/zanata-python-client-1.3.14-3.fc20.src.rpm Looks good now. APPROVED. Thanks Parag for review New Package SCM Request ======================= Package Name: zanata-python-client Short Description: Python Client for Zanata Server Upstream URL: http://zanata.org Owners: anishpatil Branches: f20 f21 epel7 InitialCC: i18n-team Git done (by process-git-requests). zanata-python-client-1.3.14-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/zanata-python-client-1.3.14-3.fc20 Package Change Request ====================== Package Name: zanata-python-client New Branches: f21 Owners: anishpatil Git done (by process-git-requests). zanata-python-client-1.3.14-3.fc20 has been pushed to the Fedora 20 testing repository. zanata-python-client-1.3.14-3.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: zanata-python-client New Branches: el6 epel7 Owners: anishpatil InitialCC: i18n-team Git done (by process-git-requests). el6 exists. |