Bug 1122216
| Summary: | Review Request: nodejs-core-util-is - The util.is functions introduced in Node v0.12 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade, pnemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-23 18:48:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1122233 | ||
|
Description
Ralph Bean
2014-07-22 19:04:12 UTC
Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-core-util-is.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + Source verified with upstream as (sha256sum) srpm tarball :1a3250e48db786b1935b387d0df5ae8e4a237555207d36f4345b06725cc5f192 upstream tarball :1a3250e48db786b1935b387d0df5ae8e4a237555207d36f4345b06725cc5f192 + License "MIT" is valid and is included in its source file. + rest looks following packaging guidelines. Suggestions: 1) No testing related lines available so remove empty lines 4-5. APPROVED. New Package SCM Request ======================= Package Name: nodejs-core-util-is Short Description: The util.is functions introduced in Node v0.12 Upstream URL: https://npmjs.org/package/core-util-is Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: Git done (by process-git-requests). nodejs-core-util-is-1.0.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-core-util-is-1.0.1-1.fc20 nodejs-core-util-is-1.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-core-util-is-1.0.1-1.fc19 Buildroot overrides have been created. nodejs-core-util-is-1.0.1-1.fc20 has been pushed to the Fedora 20 stable repository. nodejs-core-util-is-1.0.1-1.fc19 has been pushed to the Fedora 19 stable repository. Package Change Request ====================== Package Name: nodejs-core-util-is New Branches: el6 Owners: pnemade Forgot to add that POC of this package has approved for above request see https://bugzilla.redhat.com/show_bug.cgi?id=1179942#c4 Git done (by process-git-requests). |