Bug 1122231
| Summary: | Review Request: nodejs-proxy-agent - Maps proxy protocols to http.Agent implementations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-08-21 13:15:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1122225, 1122226, 1122228, 1122239 | ||
| Bug Blocks: | 956806, 1122244 | ||
|
Description
Ralph Bean
2014-07-22 19:05:25 UTC
New Package SCM Request ======================= Package Name: nodejs-proxy-agent Short Description: Maps proxy protocols to http.Agent implementations Upstream URL: https://npmjs.org/package/proxy-agent Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: I don't see a review here? :) (In reply to Kevin Fenzi from comment #2) > I don't see a review here? :) Astute, Kevin. :( Sorry about that. Review: + mock build is successful for f22. + rpmlint output on rpms gave nodejs-proxy-agent.noarch: W: spelling-error Summary(en_US) http -> HTTP nodejs-proxy-agent.noarch: W: spelling-error %description -l en_US proxying -> propping nodejs-proxy-agent.noarch: W: spelling-error %description -l en_US http -> HTTP nodejs-proxy-agent.noarch: W: only-non-binary-in-usr-lib nodejs-proxy-agent.noarch: W: dangling-symlink /usr/lib/node_modules/proxy-agent/node_modules/pac-proxy-agent /usr/lib/node_modules/pac-proxy-agent nodejs-proxy-agent.noarch: W: dangling-symlink /usr/lib/node_modules/proxy-agent/node_modules/https-proxy-agent /usr/lib/node_modules/https-proxy-agent nodejs-proxy-agent.noarch: W: dangling-symlink /usr/lib/node_modules/proxy-agent/node_modules/lru-cache /usr/lib/node_modules/lru-cache nodejs-proxy-agent.noarch: W: dangling-symlink /usr/lib/node_modules/proxy-agent/node_modules/socks-proxy-agent /usr/lib/node_modules/socks-proxy-agent nodejs-proxy-agent.noarch: W: dangling-symlink /usr/lib/node_modules/proxy-agent/node_modules/http-proxy-agent /usr/lib/node_modules/http-proxy-agent nodejs-proxy-agent.src: W: spelling-error Summary(en_US) http -> HTTP nodejs-proxy-agent.src: W: spelling-error %description -l en_US proxying -> propping nodejs-proxy-agent.src: W: spelling-error %description -l en_US http -> HTTP 2 packages and 0 specfiles checked; 0 errors, 12 warnings. + Source verified with upstream as (sha256sum) srpm tarball :85a664fd213d69002873899d230dcc1f0c66b51ce7f447d5b5efde57d6bf09c6 upstream tarball :85a664fd213d69002873899d230dcc1f0c66b51ce7f447d5b5efde57d6bf09c6 + License "MIT" is valid and is included in README.md file as %doc + rest looks following packaging guidelines. APPROVED. New Package SCM Request ======================= Package Name: nodejs-proxy-agent Short Description: Maps proxy protocols to http.Agent implementations Upstream URL: https://npmjs.org/package/proxy-agent Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: Git done (by process-git-requests). Built in rawhide. nodejs-proxy-agent-1.1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-proxy-agent-1.1.0-1.fc20 nodejs-proxy-agent-1.1.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-proxy-agent-1.1.0-1.fc19 nodejs-proxy-agent-1.1.0-1.fc19 has been pushed to the Fedora 19 stable repository. nodejs-proxy-agent-1.1.0-1.fc20 has been pushed to the Fedora 20 stable repository. |