Bug 1122245
| Summary: | Review Request: nodejs-thunkify - Turn callbacks, arrays, generators, and more into thunks | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-07-23 18:51:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1122229 | ||
|
Description
Ralph Bean
2014-07-22 19:06:44 UTC
Review: + mock build is successful for f22. + rpmlint output on rpms gave nodejs-thunkify.noarch: W: only-non-binary-in-usr-lib nodejs-thunkify.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + Source verified with upstream as (sha256sum) srpm tarball :38308ec23e761e69077652851759db00cf79d43f7830cb99f10c02cfa8b19179 upstream tarball :38308ec23e761e69077652851759db00cf79d43f7830cb99f10c02cfa8b19179 + License "MIT" is valid. + rest looks following packaging guidelines. Suggestions: 1) include Readme.md as %doc 2) Ask upstream to provide license text in any way with upstream tarball. APPROVED. New Package SCM Request ======================= Package Name: nodejs-thunkify Short Description: Turn callbacks, arrays, generators, and more into thunks Upstream URL: https://npmjs.org/package/thunkify Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: Git done (by process-git-requests). nodejs-thunkify-2.1.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-thunkify-2.1.2-1.fc20 nodejs-thunkify-2.1.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-thunkify-2.1.2-1.fc19 Buildroot overrides have been created. nodejs-thunkify-2.1.2-1.fc20 has been pushed to the Fedora 20 stable repository. nodejs-thunkify-2.1.2-1.fc19 has been pushed to the Fedora 19 stable repository. |