Bug 1122515

Summary: Create application from code with a given branch - it doesn't respect the branch if it contains '/' character
Product: OpenShift Online Reporter: Balazs Varga <bvarga>
Component: MasterAssignee: Lili Nader <lnader>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2.xCC: decarr, jokerman, mfisher, mfojtik, mmccomas, zzhao
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-10 00:49:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Balazs Varga 2014-07-23 12:12:38 UTC 
Description of problem:
When I create an application from source code (not custom cartridge, application source code!) and I specify a branch which contains "/" character then it uses the master branch.


Version-Release number of selected component (if applicable):
current prod, ami-86fc35ee - devenv_4998

How reproducible:
always

Steps to Reproduce:

Create application from the web ui and fill the source code fill with a branch which contains '/' character, ex.: bvarga/bug_1000435_xxx

OR

$ rhc create-app drupal php-5.4 mysql-5.5 --from-code=https://github.com/vbalazs/drupal-quickstart.git#bvarga/bug_1012981_drupal_quickstart_generate_and_show_password

(the branch or repo above may be removed in the future)

Actual results:

It creates the application from the master branch.

Expected results:

It uses the given branch even if it contains '/'

Additional info:

It works fine if I give SHA (short or long) or a branch without '/' ex. "test".
Comment 1 Lili Nader 2014-07-28 18:04:38 UTC 
https://github.com/openshift/origin-server/pull/5666
Comment 2 openshift-github-bot 2014-07-29 19:37:20 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/ff4f22bfc4dbea7536dd0e6a14b9d3ca2c61e6a7
Bug 1122515
Comment 3 zhaozhanqi 2014-07-30 02:26:33 UTC 
Verified this bug on devenv_5027

#rhc app show drupal
drupal @ http://drupal-xxx.dev.rhcloud.com/ (uuid: 53d88e74e1479e949000001c)
------------------------------------------------------------------------------
  Domain:          xxx
  Created:         2:19 AM
  Gears:           1 (defaults to small)
  Git URL:         ssh://53d88e74e1479e949000001c.rhcloud.com/~/git/drupal.git/
  Initial Git URL: https://github.com/vbalazs/drupal-quickstart.git#bvarga/bug_1012981_drupal_quickstart_generate_and_show_password