Bug 1122691

Summary:	Live Merge: Fix engine-side flows
Product:	[Retired] oVirt	Reporter:	Greg Padgett <gpadgett>
Component:	ovirt-engine-core	Assignee:	Greg Padgett <gpadgett>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Kevin Alon Goldblatt <kgoldbla>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.5	CC:	acanan, amureini, ecohen, gklein, gpadgett, iheim, lsurette, rbalakri, yeylon
Target Milestone:	---
Target Release:	3.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	storage
Fixed In Version:	ovirt-3.5.0_rc1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-17 12:29:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1083310

Description Greg Padgett 2014-07-23 19:17:52 UTC

Multiple Live Merge fixes were merged to master and need backporting to 3.5, for the following issues:

- fix race when removing memory volumes during Live Merge
- sync VM config after Live Merge
- set active image after Live Merge of active layer
- allow successful retries of Live Merge

These are basic requirements for the feature to work properly, so testing would be included as part of the parent feature.

Comment 1 Kevin Alon Goldblatt 2014-10-06 14:13:09 UTC

Hi I need additional information in order to procede with this BZ. Please provide the relevant bugs with scenarios to reproduce and verify these scenarios.

Comment 2 Greg Padgett 2014-10-08 15:58:19 UTC

(In reply to Kevin Alon Goldblatt from comment #1)
> Hi I need additional information in order to procede with this BZ. Please
> provide the relevant bugs with scenarios to reproduce and verify these
> scenarios.

Hi Kevin,

In general, without these fixes Live Merge would be completely broken.  However, here are some specific things to verify for the various fixes:

- fix race when removing memory volumes during Live Merge
 => Attempt multiple Live Merges, removing live snapshots that contain memory volumes.  Ensure that the command completes successfully rather than terminating prematurely--that is, the disk and memory snapshots should be removed with no errors in the log.

- sync VM config after Live Merge
 => After Live Merge completes, ensure that the snapshots before and after the removed snapshot show valid disk images, which can be verified by viewing the Disk details from the Virtual Machines > Snapshots section of the web gui.  (Without this fix, disks in the removed snapshot's child would be marked Illegal.)

- set active image after Live Merge of active layer
 => After removing the active layer, ensure the VM can be started and that the Virtual Machines > Snapshot area in the GUI behaves normally (i.e. disks haven't disappeared, data doesn't refuse to load, no exceptions/errors during gui navigation in that area, etc).

- allow successful retries of Live Merge
 => If Live Merge is interrupted (e.g. host is fenced during the merge operation), you should be able to retry the operation from the UI/REST API.  Without this fix, manual cleanup had to be performed if Live Merge did not complete.

Comment 3 Sandro Bonazzola 2014-10-17 12:29:36 UTC

oVirt 3.5 has been released and should include the fix for this issue.