Bug 1122938

Summary: confusing content host identifiers
Product: Red Hat Satellite 6 Reporter: Tomas Lestach <tlestach>
Component: APIAssignee: Dustin Tsang <dtsang>
Status: CLOSED UPSTREAM QA Contact: Katello QA List <katello-qa-list>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0.4CC: bbuckingham, lpramuk, mmccune
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/6842
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-07 12:20:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Tomas Lestach 2014-07-24 12:52:49 UTC
Description of problem:
content host id and uuid are both used as content host identifiers, what is quite confusing

Version-Release number of selected component (if applicable):
Satellite-6.0.4-RHEL-6-20140716.0-Satellite-x86_64

How reproducible:
always

Steps to Reproduce:
1. Compare various content host identifiers

Actual results:
1. hammer interprets uuid as id
# hammer content-host list --organization-id 1
-------------------------------------|-----------------------------------
ID                                   | NAME                              
-------------------------------------|-----------------------------------
49eb6336-03cf-4396-8302-67d3cff2c24e | vmware194.englab.brq.redhat.com   
...

2. api documentation for "PUT /katello/api/systems/:id" says:
id /required/ UUID of the content host /Value: String

so, uuid is used as content host id

3. but the return hash of "PUT /katello/api/systems/:id" API with 'id' set to 'b7dbf416-dd8d-4ab5-95ed-ffe51100ce2c' contains:
{..., "id"=>2, ...}
it contains uuid as well: "uuid"=>"b7dbf416-dd8d-4ab5-95ed-ffe51100ce2c",
but it's confusing to update an object with a specific *id* and getting another *id* in the response

Expected results:
Hide the 'real' content host id ("id"=>2) from the user as it isn't used anywhere and is only confusing (or drop it completely)

Additional info:
What about returning both - id and uuid keys - with the same value?
{..., "id"=>"b7dbf416-dd8d-4ab5-95ed-ffe51100ce2c", "uuid"=>"b7dbf416-dd8d-4ab5-95ed-ffe51100ce2c", ...}

Comment 2 Dustin Tsang 2014-07-30 14:56:32 UTC
Created redmine issue http://projects.theforeman.org/issues/6842 from this bug

Comment 3 Bryan Kearney 2014-08-05 20:05:05 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/6842 has been closed
-------------
dustin tsang
Applied in changeset commit:katello|95ac2fdf4b16d70f8f4853fbeb7d57b3616ee8bf.

Comment 4 Bryan Kearney 2014-08-07 12:20:00 UTC
These have been closd upstream. You will see these delivered with Satellite 6.1.