Bug 1122940

Taking the review... Could you review rubygem-logstasher https://bugzilla.redhat.com/show_bug.cgi?id=1135130 ?

- the new version were released in the meantime (with the fixed issue 11 :-))

- rpmlint: rubygem-capybara_minitest_spec-doc.noarch: E: zero-length /usr/share/gems/gems/capybara_minitest_spec-1.0.2/HISTORY.md
  You can consider excluding it.

Updated:

Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-capybara_minitest_spec.spec
SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-capybara_minitest_spec-1.0.3-1.fc22.src.rpm

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
=======

- There remains the rpmlint error:

rubygem-capybara_minitest_spec-doc.noarch: E: zero-length /usr/share/gems/gems/capybara_minitest_spec-1.0.3/HISTORY.md

I think it's OK, if you know about it (and you want to keep that file).


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 7 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Ruby:
[x]: Specfile should use macros from rubygem-devel package.
[x]: Gem package should exclude cached Gem.
[x]: Gem should use %gem_install macro.
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-capybara_minitest_spec-1.0.3-1.fc22.noarch.rpm
          rubygem-capybara_minitest_spec-doc-1.0.3-1.fc22.noarch.rpm
          rubygem-capybara_minitest_spec-1.0.3-1.fc22.src.rpm
rubygem-capybara_minitest_spec.noarch: W: spelling-error Summary(en_US) Capybara -> Carapace
rubygem-capybara_minitest_spec.noarch: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers
rubygem-capybara_minitest_spec-doc.noarch: W: spelling-error Summary(en_US) capybara -> carapace
rubygem-capybara_minitest_spec-doc.noarch: W: spelling-error Summary(en_US) minitest -> mintiest, minutest, mini test
rubygem-capybara_minitest_spec-doc.noarch: W: spelling-error %description -l en_US capybara -> carapace
rubygem-capybara_minitest_spec-doc.noarch: W: spelling-error %description -l en_US minitest -> mintiest, minutest, mini test
rubygem-capybara_minitest_spec-doc.noarch: E: zero-length /usr/share/gems/gems/capybara_minitest_spec-1.0.3/HISTORY.md
rubygem-capybara_minitest_spec.src: W: spelling-error Summary(en_US) Capybara -> Carapace
rubygem-capybara_minitest_spec.src: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers
3 packages and 0 specfiles checked; 1 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint rubygem-capybara_minitest_spec-doc rubygem-capybara_minitest_spec
rubygem-capybara_minitest_spec-doc.noarch: W: spelling-error Summary(en_US) capybara -> carapace
rubygem-capybara_minitest_spec-doc.noarch: W: spelling-error Summary(en_US) minitest -> mintiest, minutest, mini test
rubygem-capybara_minitest_spec-doc.noarch: W: spelling-error %description -l en_US capybara -> carapace
rubygem-capybara_minitest_spec-doc.noarch: W: spelling-error %description -l en_US minitest -> mintiest, minutest, mini test
rubygem-capybara_minitest_spec-doc.noarch: E: zero-length /usr/share/gems/gems/capybara_minitest_spec-1.0.3/HISTORY.md
rubygem-capybara_minitest_spec.noarch: W: spelling-error Summary(en_US) Capybara -> Carapace
rubygem-capybara_minitest_spec.noarch: W: spelling-error %description -l en_US matchers -> marchers, matches, catchers
2 packages and 0 specfiles checked; 1 errors, 6 warnings.
# echo 'rpmlint-done:'



Requires
--------
rubygem-capybara_minitest_spec-doc (rpmlib, GLIBC filtered):
    rubygem-capybara_minitest_spec

rubygem-capybara_minitest_spec (rpmlib, GLIBC filtered):
    ruby(rubygems)
    rubygem(capybara)
    rubygem(minitest)



Provides
--------
rubygem-capybara_minitest_spec-doc:
    rubygem-capybara_minitest_spec-doc

rubygem-capybara_minitest_spec:
    rubygem(capybara_minitest_spec)
    rubygem-capybara_minitest_spec



Source checksums
----------------
https://rubygems.org/gems/capybara_minitest_spec-1.0.3.gem :
  CHECKSUM(SHA256) this package     : 3ba58352fc97d0d7d9c28243a16bd7584cd56bb6ac82ec5ea37c71e31d7feb27
  CHECKSUM(SHA256) upstream package : 3ba58352fc97d0d7d9c28243a16bd7584cd56bb6ac82ec5ea37c71e31d7feb27


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1122940
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Ruby, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

====

Package approved!

New Package SCM Request
=======================
Package Name: rubygem-capybara_minitest_spec
Short Description: Capybara + MiniTest::Spec
Upstream URL: https://github.com/ordinaryzelig/capybara_minitest_spec
Owners: jstribny
Branches: f21
InitialCC:

Git done (by process-git-requests).