Bug 1122944

Summary:	Review Request: rubygem-jquery-datatables-rails - jQuery datatables for rails
Product:	[Fedora] Fedora	Reporter:	Josef Stribny <jstribny>
Component:	Package Review	Assignee:	Mamoru TASAKA <mtasaka>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hhorak, package-review
Target Milestone:	---	Flags:	mtasaka: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-jquery-datatables-rails-2.2.3-1.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-24 14:21:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Josef Stribny 2014-07-24 12:57:43 UTC

Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-jquery-datatables-rails.spec
SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-jquery-datatables-rails-2.1.10.0.3-1.fc22.src.rpm
Description: This gem packages the jQuery DataTables plugin for the Rails 3.1+ asset pipeline. It provides all the basic DataTables files, and a few of
the extras.
Fedora Account System Username: jstribny

Comment 1 Mamoru TASAKA 2014-09-14 16:19:19 UTC

Some comments

* rpmlint about E: script-without-shebang
  - There are many files with executable permission (including image
    files) which should not have. Please modify permission.

* %license
  - Now we prefer to use %license for licensing files.

! Latest version
  - (not a blocker) please consider to upgrade to the latest 2.2.3.

Comment 2 Josef Stribny 2014-09-16 10:52:18 UTC

Updated and fixed:

Spec: http://data-strzibny.rhcloud.com/obs/rubygem-jquery-datatables-rails.spec
SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-jquery-datatables-rails-2.2.3-1.fc22.src.rpm

Comment 3 Mamoru TASAKA 2014-09-21 16:49:18 UTC

Approving.

-------------------------------------------------------
  This package (rubygem-jquery-datatables-rails) is 
  APPROVED by mtasaka
-------------------------------------------------------

Comment 4 Josef Stribny 2014-09-22 05:34:23 UTC

New Package SCM Request
=======================
Package Name: rubygem-jquery-datatables-rails
Short Description: jQuery datatables for Rails
Upstream URL: https://github.com/rweng/jquery-datatables-rails
Owners: jstribny
Branches: f21
InitialCC:

Comment 5 Gwyn Ciesla 2014-09-23 12:15:54 UTC

Git done (by process-git-requests).