Bug 1123069

Summary: Review Request: nodejs-resumer - A stream that starts paused and resumes on the next tick
Product: [Fedora] Fedora Reporter: Tom Hughes <tom>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review, panemade
Target Milestone: ---Flags: panemade: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nodejs-resumer-0.0.0-1.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-05 03:56:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 956806, 1005982    

Description Tom Hughes 2014-07-24 18:48:35 UTC
Spec URL: http://download.compton.nu/nodejs/nodejs-resumter.spec
SRPM URL: http://download.compton.nu/nodejs/nodejs-resumer-0.0.0-1.fc20.src.rpm
Fedora Account System Username: tomh

Description:
A through stream that starts paused and resumes on the next tick.

Comment 2 Parag AN(पराग) 2014-10-23 10:18:58 UTC
Review:

+ mock build is successful for f22.

+ rpmlint output on rpms gave
nodejs-resumer.noarch: W: only-non-binary-in-usr-lib
nodejs-resumer.noarch: W: dangling-symlink /usr/lib/node_modules/resumer/node_modules/through /usr/lib/node_modules/through
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball     :9830d5e074876e38d9652bf385d97d9fc469dbf6f86a3275e551f648ad538bc2
upstream tarball :9830d5e074876e38d9652bf385d97d9fc469dbf6f86a3275e551f648ad538bc2

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines.

APPROVED.

Comment 3 Tom Hughes 2014-10-23 10:24:09 UTC
New Package SCM Request
=======================
Package Name: nodejs-resumer
Short Description: A stream that starts paused and resumes on the next tick
Upstream URL: https://github.com/substack/resumer
Owners: tomh
Branches: f20 f21
InitialCC: jamielinux

Comment 4 Gwyn Ciesla 2014-10-23 12:26:51 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2014-10-23 16:47:01 UTC
nodejs-resumer-0.0.0-1.fc20,nodejs-object-inspect-1.0.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nodejs-resumer-0.0.0-1.fc20,nodejs-object-inspect-1.0.0-1.fc20

Comment 6 Fedora Update System 2014-10-27 03:27:35 UTC
nodejs-resumer-0.0.0-1.fc20, nodejs-object-inspect-1.0.0-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 7 Fedora Update System 2014-11-05 03:56:03 UTC
nodejs-resumer-0.0.0-1.fc20, nodejs-object-inspect-1.0.0-1.fc20 has been pushed to the Fedora 20 stable repository.